Skip to content

[Notifier] Add Yunpian Notifier Bridge #42239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2021
Merged

[Notifier] Add Yunpian Notifier Bridge #42239

merged 1 commit into from
Jul 25, 2021

Conversation

welcoMattic
Copy link
Member

@welcoMattic welcoMattic commented Jul 23, 2021 •
edited
Loading

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR symfony/symfony-docs#15553

This PR provides support for Yunpian in Notifier. Yunpian is a Chinese SMS provider.
I based this bridge on this repository https://github.com/siganushka/yunpian-notifier, I made some fixes, and add tests.

It only supports single SMS send. Yunpian provides a batch mode which I have never used.

@welcoMattic welcoMattic requested a review from OskarStark as a code owner July 23, 2021 13:22
@welcoMattic welcoMattic force-pushed the yunpian-notifier branch 4 times, most recently from 396b376 to 1b16cb3 Compare July 23, 2021 13:59
OskarStark
OskarStark approved these changes Jul 23, 2021
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor

@welcoMattic welcoMattic force-pushed the yunpian-notifier branch 2 times, most recently from caaee22 to e81ce2c Compare July 23, 2021 14:35
Nyholm
Nyholm requested changes Jul 24, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR

I just had minors.

@OskarStark OskarStark requested a review from Nyholm July 24, 2021 10:31
Nyholm
Nyholm approved these changes Jul 25, 2021
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@OskarStark
Copy link
Contributor

Please create a recipe PR, thank you

@OskarStark
Copy link
Contributor

Thanks Mathieu for working on this feature, this is much appreciated.

@OskarStark OskarStark merged commit 839d1ac into symfony:5.4 Jul 25, 2021
@welcoMattic welcoMattic mentioned this pull request Jul 25, 2021
Merged
@welcoMattic welcoMattic deleted the yunpian-notifier branch July 25, 2021 09:14
@welcoMattic
Copy link
Member Author

@OskarStark The recipe PR is open symfony/recipes#978

This was referenced Nov 5, 2021
Merged
Merged
@siganushka
Copy link
Contributor

@welcoMattic You did a work job, awesome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@Nyholm Nyholm Nyholm approved these changes

@derrabus derrabus Awaiting requested review from derrabus

@jderusse jderusse Awaiting requested review from jderusse

Assignees
No one assigned
Labels
Feature Notifier Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@welcoMattic @OskarStark @siganushka @Nyholm @carsonbot