[Cache] Allow decorating each cache.pool as debug adapters
#42241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
cache.pool as debug adapterscache.pool as debug adapters
|
That's an interesting approach, but to be honest I had another one in mind: That would give better DX, by giving proper error messages. |
|
Closing in favor of #43148 |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 24, 2021
…ion fails (nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [Cache] Throw ValueError in debug mode when serialization fails | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes | Deprecations? | - | Tickets | Fix #41685 | License | MIT | Doc PR | - This feature allows spotting mistakes at the dev stage when trying to store unserializable objects (typically a closure) into a cache. This PR replaces #42241 with a simpler and more focused approach: here we fail via a simple `ValueError`, which won't get caught by any try/catch into the Cache component, and we fail only when serialization fails - not on any failures of cache pool methods. Commits ------- 0d3ede7 [Cache] Throw ValueError in debug mode when serialization fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DebugAdapterto throw exception on failing savecache.exception_on_saveas parameter to configure the feature@nicolas-grekas could you provide some initial feedback on whether this implementation is in the right direction?