Skip to content

[WebProfilerBundle] Use multi line comment #42249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2021
Merged

[WebProfilerBundle] Use multi line comment #42249

merged 1 commit into from
Jul 24, 2021

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jul 24, 2021

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #42248
License MIT
Doc PR

Since the css/js is "fake minified" (we just remove the new line character) we cannot use //. See comment in the head of base_js.html.twig:

  {# Caution: the contents of this file are processed by Twig before loading
   them as JavaScript source code. Always use '/*' comments instead
   of '//' comments to avoid impossible-to-debug side-effects #}

I also added a small test to enforce this.

@Nyholm Nyholm mentioned this pull request Jul 24, 2021
Closed
@fabpot
Copy link
Member

fabpot commented Jul 24, 2021

Thank you @Nyholm.

@fabpot fabpot merged commit f5bc4a1 into symfony:5.4 Jul 24, 2021
@Nyholm
Copy link
Member Author

Nyholm commented Jul 24, 2021

Thank you for merging

@Nyholm Nyholm deleted the issue-42248 branch July 24, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Status: Reviewed WebProfilerBundle
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web Profiler code not beeing injected properly
3 participants
@Nyholm @fabpot @carsonbot