Skip to content

[Messenger] Allow using user's serializer for message do not fit the expected JSON structure #42257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2021
Merged

[Messenger] Allow using user's serializer for message do not fit the expected JSON structure #42257

merged 1 commit into from
Sep 27, 2021

Conversation

welcoMattic
Copy link
Member

@welcoMattic welcoMattic commented Jul 26, 2021 •
edited
Loading

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #42072
License MIT
Doc PR symfony/symfony-docs#...

It allows user to use their own serializer to decode messages that do not fit the expected JSON structure ({ "message": { "body": "", "headers": {} } }).

Once this PR will be ok, I'll report the fix in Beanstalkd, SQS, and Doctrine Transports

@welcoMattic welcoMattic requested a review from sroze as a code owner July 26, 2021 12:13
@carsonbot carsonbot added this to the 5.3 milestone Jul 26, 2021
@welcoMattic welcoMattic force-pushed the redis-external-msg branch 9 times, most recently from 93bfcd4 to 536e759 Compare July 27, 2021 09:20
@welcoMattic
Copy link
Member Author

welcoMattic commented Jul 27, 2021 •
edited
Loading

@carsonbot find me a reviewer please (I'm discovering that Carson can do more things than automate status in reaction to git actions 😄 )

@carsonbot
Copy link

@jonashrem could maybe review this PR?

@welcoMattic welcoMattic force-pushed the redis-external-msg branch 6 times, most recently from 80be65a to d529c6b Compare July 27, 2021 16:42
@welcoMattic
Copy link
Member Author

Status: Needs review

@carsonbot carsonbot changed the title Allow using user's serializer for message do not fit the expected JSON structure [Messenger] Allow using user's serializer for message do not fit the expected JSON structure Jul 30, 2021
@lyrixx lyrixx modified the milestones: 5.3, 5.4 Sep 13, 2021
@welcoMattic
Copy link
Member Author

This PR is ready to be reviewed

lyrixx
lyrixx approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@lyrixx lyrixx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I didn't test it

@fabpot fabpot changed the base branch from 5.3 to 5.4 September 27, 2021 09:28
@fabpot
Copy link
Member

fabpot commented Sep 27, 2021

Merging in 5.4 as this is a new feature.

@fabpot
Copy link
Member

fabpot commented Sep 27, 2021

Thank you @welcoMattic.

@fabpot fabpot merged commit d1fd413 into symfony:5.4 Sep 27, 2021
@fabpot fabpot mentioned this pull request Sep 27, 2021
Closed
@welcoMattic welcoMattic deleted the redis-external-msg branch September 27, 2021 10:10
@alexander-schranz
Copy link
Contributor

@welcoMattic Good work 👍

@xabbuh xabbuh mentioned this pull request Oct 22, 2021
Merged
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@lyrixx lyrixx lyrixx approved these changes

@alexander-schranz alexander-schranz alexander-schranz approved these changes

@chalasr chalasr chalasr approved these changes

@sroze sroze Awaiting requested review from sroze

Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[Messenger] [Redis] Can not consume messages published by third party in Redis
6 participants
@welcoMattic @carsonbot @fabpot @alexander-schranz @lyrixx @chalasr