[HttpFoundation] Fixed type mismatch #42289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Jul 27, 2021
Sure, why not. 🙂 |
|
That was kind of a stupid question, I was just being lazy 🙈 Test is here now :) |
xabbuh
approved these changes
Jul 27, 2021
|
Thank you @Toflar. |
|
What about 5.3 branch? Is this patch going to be applied to 5.3? |
|
Yes. |
|
I guess this can be reverted, as it was actually a bug with the |
This was referenced Jul 29, 2021
Merged
Merged
Merged
|
@bobvandevijver Actually, we need this change again for PHP 8.1 as passing |
|
Yes. Up for a PR? 🙂 |
|
Thanks for the fix. I also had this error with Sf 5.3.5. 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
in case there's no
cache-controlresponse header. This doesn't happen by default as theResponseis initialized with one by default but any class extending from it can adjust that. Technically speaking, it's not disallowed to have nocache-controlheader set.Want me to add a test for that? :)