Skip to content

[TwigBridge] do not merge label classes into expanded choice labels #42323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2021
Merged

[TwigBridge] do not merge label classes into expanded choice labels #42323

merged 1 commit into from
Nov 19, 2021

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 30, 2021

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #40005
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.4 milestone Jul 30, 2021
@xabbuh xabbuh changed the title [TwigBridge] do not merge label classes into choice labels [TwigBridge] do not merge label classes into expanded choice labels Jul 30, 2021
@xabbuh
Copy link
Member Author

xabbuh commented Jul 30, 2021

CI failure looks related

Status: Needs work

@xabbuh xabbuh force-pushed the issue-40005 branch 3 times, most recently from a0c4375 to 4ec3be7 Compare August 16, 2021 07:27
@xabbuh
Copy link
Member Author

xabbuh commented Aug 16, 2021

After having another look I fail to see how the failure is related.

Status: Needs Review

@carsonbot
Copy link

Hey!

I think @ker0x has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@xabbuh
Copy link
Member Author

xabbuh commented Nov 13, 2021

ping @symfony/mergers

@fancyweb
Copy link
Contributor

Thank you @xabbuh.

@fancyweb fancyweb merged commit eee7b80 into symfony:4.4 Nov 19, 2021
@xabbuh xabbuh deleted the issue-40005 branch November 19, 2021 09:57
This was referenced Nov 22, 2021
Merged
Merged
Merged
Merged
@stof stof mentioned this pull request Nov 29, 2021
Closed
xabbuh referenced this pull request in symfony/twig-bridge Dec 8, 2021
@xabbuh
do not merge label classes into expanded choice labels
55a4045
@Seb33300 Seb33300 mentioned this pull request Mar 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@welcoMattic welcoMattic welcoMattic approved these changes

@derrabus derrabus derrabus approved these changes

@yceruto yceruto yceruto approved these changes

@ogizanagi ogizanagi ogizanagi approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug Ready Status: Reviewed TwigBridge
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
8 participants
@xabbuh @carsonbot @fancyweb @welcoMattic @derrabus @yceruto @ogizanagi @chalasr