Skip to content

[HttpFoundation] Add litespeed_finish_request to Response #42332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

thomas2411
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets #42293
License MIT

For now Litespeed has dropped support for fastcgi_finish_request function due to some problems: php/php-src@ccf051c so when Litespeed is being used on a server instead of Apache, then there is no possibility to use fastcgi_finish_request function as the alias for litespeed_finish_request is turned off.

@OskarStark
Copy link
Contributor

CleanShot 2021-07-30 at 18 12 54@2x

It looks like your commiter email is not associated with your Github Account

@thomas2411
Copy link
Contributor Author

Oh, indeed. I have just added the email used to commit to my account on GitHub in Settings > Emails. I have verified it. Is it OK?

@OskarStark OskarStark changed the title [HttpFoundation] Add litespeed_finish_request to Response [HttpFoundation] Add litespeed_finish_request to Response Aug 1, 2021
@fabpot
Copy link
Member

fabpot commented Aug 6, 2021

Thank you @thomas2411.

@fabpot fabpot merged commit bb68baf into symfony:5.4 Aug 6, 2021
This was referenced Nov 5, 2021
@yannisc
Copy link

yannisc commented Mar 1, 2022

This change makes my OpenLiteSpeed requests to take 500ms instead of 50ms that they needed before. Any idea on why might this happen?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants