Skip to content

[Validator] Remove internal from ConstraintViolationAssertion #42337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jordisala1991
Copy link
Contributor

@jordisala1991 jordisala1991 commented Jul 31, 2021

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #42310
License MIT
Doc PR symfony/symfony-docs#...

As requested on the issue, I made this class final instead of internal and the construct method is internal.

@jordisala1991 jordisala1991 changed the title Remove internal from ConstraintViolationAssertion Remove internal from ConstraintViolationAssertion Jul 31, 2021
@carsonbot carsonbot changed the title Remove internal from ConstraintViolationAssertion [Validator] Remove internal from ConstraintViolationAssertion Aug 1, 2021
@OskarStark OskarStark added this to the 5.4 milestone Aug 1, 2021
@OskarStark
Copy link
Contributor

OskarStark commented Aug 1, 2021

Thanks Jordi and congrats on your first contribution to Symfony 🎉 👏

@OskarStark OskarStark merged commit f2ef55c into symfony:5.4 Aug 1, 2021
@jordisala1991 jordisala1991 deleted the feature/remove-internal-constraint-assertion branch August 1, 2021 18:09
This was referenced Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Would it be possible to remove @internal from ConstraintViolationAssertion ?
5 participants