[DomCrawler] Added Crawler::innerText() method #42338
Conversation
| /** | ||
| * Tests that innerText() returns only text that is the direct descendent of the current node, in contrast to | ||
| * text() that returns the text of all child nodes. | ||
| */ |
There was a problem hiding this comment.
The comment is not needed
There was a problem hiding this comment.
A test scenario is not needed, in a technical sense, but it is needed in a maintainability sense. It conveys what the original intent of the test is, which helps greatly in determining how to fix it when it should break in future.
There was a problem hiding this comment.
From my POV we can keep it, but testInnerText() method name makes clear what's the point here 🤷♂️
There was a problem hiding this comment.
Perhaps, but I think writing test scenarios is a good habit to be into.
There was a problem hiding this comment.
Do we use this anywhere else in the DomCrawler's test suite? If not, I am in favour of removing the comment and, if necessary, change the method name to something like testInnerTextReturnsContentOfDirectDescendantTextNodesExclusively().
There was a problem hiding this comment.
Strongly disagree. Prose is much easier to read as space-separated words instead of stuffing entire sentences into camel-cased method names.
There was a problem hiding this comment.
in this case testInnerText() is enough
| */ | ||
| public function innerText(): string | ||
| { | ||
| return $this->filterXPath('.//text()')->text(); |
There was a problem hiding this comment.
This can also be expressed as child::node()/text(). I don't know which is "better".
|
@Bilge Can you take suggestions into account? |
|
@fabpot Suggestions have been taken into account. |
|
Thank you @Bilge. |
Adds a method to get the inner text that is directly descended from the current node only, ignoring text nodes in any child nodes.