[DoctrineBridge] Typehint against doctrine/persistence interfaces #42360
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0cac79c to
378f2f0
Compare
|
Failing test is unrelated with the changes, it's red due to an error during composer install. |
Nyholm
approved these changes
Aug 3, 2021
|
This is not a BC break as it is just a private method. |
derrabus
approved these changes
Aug 4, 2021
|
Good catch, thanks @malarzm. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symfony/doctrine-bridge@564157d#diff-fcc6368334975000298e4227d2500f909f82280f79ca1d4499a9a5093a594a7dR180 went a bit too aggressive with typehints using signatures from ORM instead of
doctrine/persistencebreaking ODM's integration.