[Form] Deprecate calling FormErrorIterator::children() if the current element is not iterable #42387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
W0rma
commented
Aug 5, 2021
| Q | A |
|---|---|
| Branch? | 5.4 for features |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | yes |
| Tickets | #42301 (comment) |
| License | MIT |
| Doc PR |
derrabus
approved these changes
Aug 5, 2021
xabbuh
requested changes
Aug 5, 2021
f8910cd to
03a2a13
Compare
xabbuh
reviewed
Aug 5, 2021
6de432e to
9cf7d8a
Compare
…lement is not iterable
9cf7d8a to
d8e74fc
Compare
xabbuh
approved these changes
Aug 14, 2021
fabpot
approved these changes
Aug 15, 2021
|
Thank you @W0rma. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 19, 2021
…rma) This PR was merged into the 6.0 branch. Discussion ---------- [Form] Remove deprecated code from FormErrorIterator | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Follow-up of #42387 | License | MIT | Doc PR | Remove deprecated code from `FormErrorIterator::children()` Commits ------- 0798623 Throw exception if child element is not iterable
symfony-splitter
pushed a commit
to symfony/form
that referenced
this pull request
Aug 19, 2021
…rma) This PR was merged into the 6.0 branch. Discussion ---------- [Form] Remove deprecated code from FormErrorIterator | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Follow-up of symfony/symfony#42387 | License | MIT | Doc PR | Remove deprecated code from `FormErrorIterator::children()` Commits ------- 07986234cc Throw exception if child element is not iterable
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.