[FrameworkBundle] remove dead conditions in Translation Commands #42390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a trivial removal of unused code I stumbled upon while debugging #42361. In the original code:
The second part of the condition
isset($transPaths[1])
will always evaluate to true, since$targetPath
is just set 3 lines above but only has a single element.This check was originally to support legacy paths which was removed in b6eb1f4:
TranslationDebugCommand.php
TranslationUpdateCommand.php
Rebased from 5.3 to 5.4, see #42362
/cc @fabpot