[RFC][Session] Make the PDO handler looks less hacky #4244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
that referenced
this pull request
May 10, 2012
Commits ------- b865b09 [Session] Fix the PDO handler for mysql concurrent write Discussion ---------- [RFC][Session] Make the PDO handler looks less hacky Related discussion: ebc2f01#commitcomment-1304221 The current code works but looks hacky (`$dbTimeCol = CASE WHEN $dbTimeCol = :time THEN (VALUES($dbTimeCol) + 1) ELSE VALUES($dbTimeCol) END`). Todo: wrap the mysql specific code in a `try...catch` if we choose this PR way (to be consistent with all other PDO invocations). --------------------------------------------------------------------------- by travisbot at 2012-05-10T07:50:39Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1293131) (merged b865b09 into 48099a8).
fabpot
added a commit
that referenced
this pull request
May 10, 2012
Commits ------- 51b753a [Session] cleanup of the PDO storage Discussion ---------- [Session] cleanup of the PDO storage and adding what was missing from #4244 --------------------------------------------------------------------------- by travisbot at 2012-05-10T10:40:33Z This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1293901) (merged 51b753a into 6259429).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related discussion: ebc2f01#commitcomment-1304221
The current code works but looks hacky (
$dbTimeCol = CASE WHEN $dbTimeCol = :time THEN (VALUES($dbTimeCol) + 1) ELSE VALUES($dbTimeCol) END).Todo: wrap the mysql specific code in a
try...catchif we choose this PR way (to be consistent with all other PDO invocations).