Add generic types to traversable implementations #42471
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Symfony/Component/Finder/Iterator/DateRangeFilterIterator.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Finder/Iterator/SizeRangeFilterIterator.php
Outdated
Show resolved
Hide resolved
|
👍🏼 for the workflow part |
|
Ldap's QueryInterface declares |
franmomu
reviewed
Aug 12, 2021
0b5c0de to
170a802
Compare
5a761ed to
9a03d29
Compare
9a03d29 to
591b066
Compare
stof
approved these changes
Nov 3, 2021
591b066 to
7f824fc
Compare
|
Thank you @derrabus. |
fabpot
added a commit
that referenced
this pull request
Nov 4, 2021
This PR was merged into the 5.4 branch. Discussion ---------- Fix more generic types | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | N/A Some changes I wanted to push to #42471, but then it got merged already. 😇 Commits ------- c54d61e Fix more generic types
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since tool support for generic types is growing, I wanted to give it a try and add generics to our traversable implementations. This should help Psalm to understand our code better. Furthermore, it helps app developers with running static code analysis on their own codebases.
Marking this as WIP for now until I reviewed all errors reported by Psalm.