Skip to content

Add return types to bundles #42500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2021

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Aug 12, 2021

Q A
Branch? 6.0
Bug fix? no
New feature? yes
Deprecations? no
Tickets #40154
License MIT
Doc PR -

Extracted from #42496

Bundles should be the safest to patch since their classes should be more rarely extended.

@nicolas-grekas
Copy link
Member Author

🍏

@wouterj
Copy link
Member

wouterj commented Aug 12, 2021

Similar to #42513, if these changes are automated, I would appreciate if we can block this merge until #41613 is merged (to avoid merge conflicts in that big PR). Maybe it's good to move the SecurityBundle in the other PR, to unlock the other bundles.

@nicolas-grekas
Copy link
Member Author

SecurityBundle now moved to #42513

@nicolas-grekas nicolas-grekas merged commit bddd980 into symfony:6.0 Aug 13, 2021
@nicolas-grekas nicolas-grekas deleted the return-types-bundles branch August 13, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants