[Security] Deprecate built-in authentication entry points #42516
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2aa052f to
9ca3cc7
Compare
Nyholm
requested changes
Aug 12, 2021
src/Symfony/Bundle/SecurityBundle/Resources/config/security_listeners.php
Show resolved
Hide resolved
src/Symfony/Component/Security/Http/EntryPoint/FormAuthenticationEntryPoint.php
Show resolved
Hide resolved
chalasr
reviewed
Aug 12, 2021
src/Symfony/Component/Security/Http/EntryPoint/BasicAuthenticationEntryPoint.php
Outdated
Show resolved
Hide resolved
9ca3cc7 to
c85fadd
Compare
|
Psalm error is expected (due to the BC layer). This PR is ready |
chalasr
reviewed
Aug 14, 2021
src/Symfony/Bundle/SecurityBundle/Resources/config/security_listeners.php
Show resolved
Hide resolved
3dd4145 to
85eee2f
Compare
chalasr
reviewed
Aug 15, 2021
This logic is now included in the authenticators
85eee2f to
c247b37
Compare
chalasr
approved these changes
Aug 15, 2021
fabpot
approved these changes
Aug 16, 2021
|
Thank you @wouterj. |
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last item from #41613.
Entry point logic is now included in the related build in authenticators, we should deprecate these unused classes (and remove them in 6.0). The interface has to be kept, as this implemented by the authenticators (and can be used to customize the entry points in an app).
I've also deprecated the retry entry point and included the code in
ChannelListenerdirectly. This entry point has never made sense to me, as it's not related to authentication imho.