[DependencyInjection] Sort services in service locator according to priority #42532
Conversation
BoShurik
commented
Aug 13, 2021
•
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| Tickets | Fix #42506 |
| License | MIT |
| Doc PR | - |
| @@ -102,7 +102,6 @@ public static function register(ContainerBuilder $container, array $refMap, stri | |||
| } | |||
| $refMap[$id] = new ServiceClosureArgument($ref); | |||
| } | |||
| ksort($refMap); | |||
There was a problem hiding this comment.
As I understand sort here is for easy testing
|
Hey! I think @fancyweb has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
|
Can you please add a test case that covers the new behavior? |
|
Oh, and please have a look at failing test cases. |
|
Friendly ping @BoShurik |
|
@nicolas-grekas yes, it's in my todo-list for this week |
|
@nicolas-grekas I am not sure how to fix |
no need to exclude: we should patch 4.4 instead to relax the test case, which is too strict apparently |
|
Thank you @BoShurik. |
… according to priority (BoShurik) This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Sort services in service locator according to priority | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #42506 | License | MIT | Doc PR | - Commits ------- c67c2df Sort services in service locator according to priority