[Console][FrameworkBundle] Add DotenvDebugCommand #42580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

fabpot merged 1 commit into symfony:5.4 from chr-hertel:dotenv-debug-command

Oct 16, 2021

Contributor

chr-hertel commented Aug 15, 2021 •

edited

Loading

Q	A
Branch?	5.4
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	Fix #41958
License	MIT
Doc PR	symfony/symfony-docs#15734

Command Implementation
Tests
Docs

carsonbot added Status: Needs Review Dotenv Feature labels

ro0NL reviewed

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Command/DotenvDebugCommand.php Outdated Show resolved Hide resolved

ro0NL reviewed

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Command/DotenvDebugCommand.php Outdated Show resolved Hide resolved

ro0NL reviewed

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Command/DotenvDebugCommand.php Outdated Show resolved Hide resolved

ro0NL reviewed

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Command/DotenvDebugCommand.php Outdated Show resolved Hide resolved

ro0NL reviewed

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Command/DotenvDebugCommand.php Outdated Show resolved Hide resolved

noniagriconomie reviewed

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Command/DotenvDebugCommand.php Outdated Show resolved Hide resolved

src/Symfony/Bundle/FrameworkBundle/Command/DotenvDebugCommand.php Outdated Show resolved Hide resolved

src/Symfony/Bundle/FrameworkBundle/Command/DotenvDebugCommand.php Outdated Show resolved Hide resolved

src/Symfony/Bundle/FrameworkBundle/Command/DotenvDebugCommand.php Outdated Show resolved Hide resolved

ro0NL reviewed

View reviewed changes

Contributor

ro0NL left a comment

(yes i want this 😁 )

src/Symfony/Bundle/FrameworkBundle/Command/DotenvDebugCommand.php Outdated Show resolved Hide resolved

src/Symfony/Bundle/FrameworkBundle/Command/DotenvDebugCommand.php Outdated Show resolved Hide resolved

src/Symfony/Bundle/FrameworkBundle/Command/DotenvDebugCommand.php Outdated Show resolved Hide resolved

nicolas-grekas added this to the 5.4 milestone

chr-hertel mentioned this pull request

[Dotenv] extending env var list with debug:dotenv command symfony/symfony-docs#15734

Merged

ro0NL reviewed

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Command/DotenvDebugCommand.php Outdated Show resolved Hide resolved

ro0NL approved these changes

View reviewed changes

Contributor

ro0NL left a comment

(travis failure is a pesky newline ;))

carsonbot added Status: Reviewed and removed Status: Needs Review labels

derrabus requested changes

View reviewed changes

Member

derrabus left a comment

Note that the Dotenv component might not be installed in a Symfony application. This new command should probably…

not be wired by FrameworkExtension
output a nice error message

… if the component is unavailable.

carsonbot added Status: Needs Work and removed Status: Reviewed labels

Contributor Author

chr-hertel commented Aug 20, 2021 •

edited

Loading

@derrabus would it be sufficient to extend the isEnabled() to not only check for $_SERVER['SYMFONY_DOTENV_VARS'] but also add class_exists(DotEnv::class)?

edit: needed some additional changes to AddConsoleCommandPass to make isEnabled really count ... not really sure about that

chr-hertel requested a review from chalasr as a code owner

August 20, 2021 22:15

carsonbot added Status: Needs Review and removed Status: Needs Work labels

chalasr reviewed

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Resources/config/console.php Outdated Show resolved Hide resolved

ro0NL reviewed

View reviewed changes

src/Symfony/Component/Console/DependencyInjection/AddConsoleCommandPass.php Outdated Show resolved Hide resolved

derrabus changed the title ~~[Dotenv] Adding DotenvDebugCommand~~ [Dotenv] Add DotenvDebugCommand

Member

derrabus commented Aug 22, 2021

We should add a line to FrameworkBundle's ChangeLog:

 * Add DotenvDebugCommand

And since your changes to FrameworkBundle rely on the is_enabled attribute you've added to the Console component, FrameworkBundle should conflict with

"symfony/console": "<5.4",

derrabus added Console FrameworkBundle and removed Dotenv labels

carsonbot changed the title ~~[Dotenv] Add DotenvDebugCommand~~ [Console][FrameworkBundle] Add DotenvDebugCommand

derrabus reviewed

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/Resources/config/console.php Outdated Show resolved Hide resolved

Member

fabpot commented Aug 22, 2021

What about moving this command to the Dotenv component (that's what we are doing for component related commands)?

chr-hertel mentioned this pull request

[Console] add is_enabled option to console.command tag #42679

Closed

chr-hertel changed the title ~~[Console][FrameworkBundle] Add DotenvDebugCommand~~ [DotEnv][FrameworkBundle] Add DotenvDebugCommand

chr-hertel changed the title ~~[DotEnv][FrameworkBundle] Add DotenvDebugCommand~~ [Dotenv][FrameworkBundle] Add DotenvDebugCommand

nicolas-grekas reviewed

View reviewed changes

src/Symfony/Component/Dotenv/CHANGELOG.md Outdated Show resolved Hide resolved

nicolas-grekas reviewed

View reviewed changes

src/Symfony/Component/Dotenv/Command/DebugCommand.php Outdated Show resolved Hide resolved

derrabus reviewed

View reviewed changes

src/Symfony/Bundle/FrameworkBundle/composer.json Outdated Show resolved Hide resolved

chr-hertel requested a review from derrabus

August 29, 2021 15:15

derrabus approved these changes

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

carsonbot changed the title ~~[Dotenv][FrameworkBundle] Add DotenvDebugCommand~~ [Console][FrameworkBundle] Add DotenvDebugCommand

chr-hertel requested a review from nicolas-grekas

September 2, 2021 06:29

carsonbot added Status: Needs Review and removed Status: Reviewed labels


          Add DotenvDebugCommand

5b2ecee

Member

derrabus commented Oct 14, 2021

@symfony/mergers Is there anything left to do here? From my POV, this PR is ready to be merged.

yceruto approved these changes

View reviewed changes

Member

yceruto left a comment

Nice addition!

carsonbot added Status: Reviewed and removed Status: Needs Review labels

fabpot approved these changes

View reviewed changes

Member

fabpot commented Oct 16, 2021

Thank you @chr-hertel.

fabpot merged commit f1b8b6e into symfony:5.4

chr-hertel deleted the dotenv-debug-command branch

October 18, 2021 16:30

javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request


          minor #15734 [Dotenv] extending env var list with debug:dotenv comman…

1d2ef41

…d (chr-hertel)

This PR was merged into the 5.4 branch.

Discussion
----------

[Dotenv] extending env var list with debug:dotenv command

Was not sure about where to put this ...

symfony/symfony#42580

Commits
-------

77d5506 extending env var list with debug:dotenv command

This was referenced Nov 5, 2021

Release v5.4.0-BETA1 #43937

Merged

Release v6.0.0-BETA1 #43939

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ro0NL ro0NL approved these changes

chalasr chalasr left review comments

noniagriconomie noniagriconomie left review comments

fabpot fabpot approved these changes

derrabus derrabus approved these changes

yceruto yceruto approved these changes

nicolas-grekas Awaiting requested review from nicolas-grekas

Labels

Console Feature FrameworkBundle Status: Reviewed