Skip to content

Add missing return types to tests/internal/final methods #42615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2021
Merged

Add missing return types to tests/internal/final methods #42615

merged 1 commit into from
Aug 18, 2021

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Thanks to #42149 again

@nicolas-grekas nicolas-grekas added this to the 5.4 milestone Aug 18, 2021
@nicolas-grekas nicolas-grekas force-pushed the more-ret-types branch 2 times, most recently from 8a1d69c to 12c31ed Compare August 18, 2021 08:02
@nicolas-grekas nicolas-grekas merged commit 682b76f into symfony:5.4 Aug 18, 2021
@nicolas-grekas nicolas-grekas deleted the more-ret-types branch August 18, 2021 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@jderusse jderusse Awaiting requested review from jderusse jderusse is a code owner

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

@sroze sroze Awaiting requested review from sroze

@wouterj wouterj Awaiting requested review from wouterj

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolas-grekas @carsonbot