[DependencyInjection] Add service_closure() to the PHP-DSL #42625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ->args([service_closure(service('foo'))]); | ||
|
|
||
| $s->set('service_closure_invalid', 'Bar') | ||
| ->args([service_closure(service('invalid_service')->nullOnInvalid())]); |
There was a problem hiding this comment.
it'd be great to be able to do this instead:
service_closure('invalid_service')->nullOnInvalid()
maybe with a new ClosureReferenceConfigurator?
There was a problem hiding this comment.
@nicolas-grekas Done. The fabbot failure is unrelated to my changes, I can apply it if you want.
nicolas-grekas
approved these changes
Aug 18, 2021
derrabus
approved these changes
Aug 18, 2021
|
@HypeMC Can you submit a PR on the docs? Or at least, give a full usage example in the PR description to help the doc team? Thank you. |
|
@fabpot Sure, I'll submit a PR sometime tomorrow. |
|
@fabpot PR(s) on the docs added: symfony/symfony-docs#15730 and symfony/symfony-docs#15731 |
|
Thank you @HypeMC. |
This was referenced Nov 5, 2021
Merged
Merged
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Mar 9, 2023
…es (HypeMC) This PR was merged into the 5.4 branch. Discussion ---------- [DependencyInjection] Add section about Service Closures Documents service closures added in symfony/symfony#21770 and symfony/symfony#41176, and the `service_closure()` PHP-DSL function added in symfony/symfony#42625 . Commits ------- f2b2fdb [DI] Add section about Service Closures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
service_closure()function to the PHP-DSL.