[Mailer] Consume a PSR-14 event dispatcher #42662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bc51e39 to
4f17de0
Compare
nicolas-grekas
approved these changes
Aug 20, 2021
ab42271 to
aa21e5d
Compare
|
By the way, should the |
You're right, it should be final. Same for the Notifier equivalent class. |
fabpot
approved these changes
Aug 20, 2021
chalasr
approved these changes
Aug 20, 2021
|
Tests are broken. |
4c991ec to
bd3f9fb
Compare
Signed-off-by: Alexander M. Turek <me@derrabus.de>
bd3f9fb to
e3c85b2
Compare
|
Thank you @derrabus. |
wouterj
reviewed
Aug 22, 2021
doekenorg
reviewed
Aug 23, 2021
fabpot
added a commit
that referenced
this pull request
Aug 25, 2021
This PR was merged into the 6.0 branch. Discussion ---------- [Mailer] Restore Transport signatures | Q | A | ------------- | --- | Branch? | 6.0 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Follow-up to #42662 | License | MIT | Doc PR | N/A Commits ------- 0d589b9 [Mailer] Restore Transport signatures
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to swap our own
EventDispatcherInterfacefor the PSR-14 one in mailer. This would allow for a deeper integration of the mailer component into non-Symfony applications that use a different event dispatcher, like https://github.com/thephpleague/event.Note that we still need Symfony's event dispatcher as a dependency, mainly because of
EventSubscriberInterface.