[Yaml] Use more concise float representation in dump #42668
Conversation
dev97
commented
Aug 21, 2021
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | no |
| New feature? | yes |
| Deprecations? | no |
| License | MIT |
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! I think @gharlan has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
|
I've no opinion on this one, @xabbuh WDYT? |
| @@ -174,7 +174,9 @@ public static function dump($value, int $flags = 0): string | |||
| $repr = str_ireplace('INF', '.Inf', $repr); | |||
| } elseif (floor($value) == $value && $repr == $value) { | |||
| // Preserve float data type since storing a whole number will result in integer value. | |||
| $repr = '!!float '.$repr; | |||
| if (false === strpos($repr, 'E')) { | |||
| $repr = $repr.'.'; | |||
There was a problem hiding this comment.
wouldn't it be even more readable by adding a trailing zero?
|
Thank you @dev97. |