[Serializer] Added functionality to parse string boolean values into object boolean fields on denormalization #42716

aurimasniekis · 2021-08-25T03:39:15Z

Q	A
Branch?	5.4
Bug fix?	no
New feature?	yes
Deprecations?	no
Tickets	Fix #42715
License	MIT
Doc PR	Will try to make soon

There are some cases where denormalizing array into an object there are situations where values are string, and it is not possible to convert them into different types using custom denormalizer without reimplementing whole object denormalization.

This pull request adds new attribute ENABLE_STRING_BOOL_VALUE into ObjectNormalizer which allows to parse string values:

["true", "yes", "on", "1"]  // => true
["false", "no", "off", "0", ""] // => false

Into representative boolean values using filter_var(..., FILTER_VALIDATE_BOOL, FILTER_NULL_ON_FAILURE) function if object field type is boolean and data is string. If the string is not one of the valid values it will throw an exception as not valid value provided.

I have chosen to use the flag FILTER_NULL_ON_FAILURE to return null if an invalid falsy value is provided instead of handling all non-truthy values as false value and throw an exception as the invalid value provided.

…ct Normalizer to try parse string boolean values if object attribute type is bool and data value is string using filter_var FILTER_VALIDATE_BOOL function

aurimasniekis · 2021-08-25T03:44:17Z

I am not sure why PHPUnit / Tests (7.2) (pull_request) broke because the broken test is from Cache component

OskarStark · 2021-08-25T06:09:01Z

src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php

+                    return $booleanValue;
+                }
+
+                throw new NotNormalizableValueException(sprintf('The value of the "%s" attribute for class "%s" must be one of "true", "yes", "on", "1", "false", "no", "off", "0", "" ("%s" given).', $attribute, $currentClass, $data));


Suggested change

throw new NotNormalizableValueException(sprintf('The value of the "%s" attribute for class "%s" must be one of "true", "yes", "on", "1", "false", "no", "off", "0", "" ("%s" given).', $attribute, $currentClass, $data));

throw new NotNormalizableValueException(sprintf('The value of the "%s" attribute for class "%s" must be one of "true", "yes", "on", "1", "false", "no", "off", "0", ""(empty string) ("%s" given).', $attribute, $currentClass, $data));

Not sure if this could help and if it makes sense

Maybe, but I was trying to follow Symfony style from exceptions around.

src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php

OskarStark · 2021-08-25T06:13:17Z

src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php

@@ -362,6 +362,83 @@ private function getDenormalizerForObjectWithBasicProperties()
        return $denormalizer;
    }

+    public function testDenormalizeBasicTypePropertiesWithStringBoolValues()


Wouldn't it be better robuste a dataProvider here? The getDenormalizerForObject...() is tight coupled to the number of values provided by the on consecutive calls, while it's not supposed to be extended in the future I guess, it feels a bit weird.

While using a dataProvider it would be less complex and you don't the onConscutiveCalls anymore

If this was my own library I would have written tests differently, but I tried to keep with the same style the all other tests are done in the file.

symfony/src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php

Lines 292 to 440 in 8e6b1f8

public function testDenormalizeBasicTypePropertiesFromXml()

{

$denormalizer = $this->getDenormalizerForObjectWithBasicProperties();

// bool

$objectWithBooleanProperties = $denormalizer->denormalize(

[

'boolTrue1' => 'true',

'boolFalse1' => 'false',

'boolTrue2' => '1',

'boolFalse2' => '0',

'int1' => '4711',

'int2' => '-4711',

'float1' => '123.456',

'float2' => '-1.2344e56',

'float3' => '45E-6',

'floatNaN' => 'NaN',

'floatInf' => 'INF',

'floatNegInf' => '-INF',

],

ObjectWithBasicProperties::class,

'xml'

);

$this->assertInstanceOf(ObjectWithBasicProperties::class, $objectWithBooleanProperties);

// Bool Properties

$this->assertTrue($objectWithBooleanProperties->boolTrue1);

$this->assertFalse($objectWithBooleanProperties->boolFalse1);

$this->assertTrue($objectWithBooleanProperties->boolTrue2);

$this->assertFalse($objectWithBooleanProperties->boolFalse2);

// Integer Properties

$this->assertEquals(4711, $objectWithBooleanProperties->int1);

$this->assertEquals(-4711, $objectWithBooleanProperties->int2);

// Float Properties

$this->assertEqualsWithDelta(123.456, $objectWithBooleanProperties->float1, 0.01);

$this->assertEqualsWithDelta(-1.2344e56, $objectWithBooleanProperties->float2, 1);

$this->assertEqualsWithDelta(45E-6, $objectWithBooleanProperties->float3, 1);

$this->assertNan($objectWithBooleanProperties->floatNaN);

$this->assertInfinite($objectWithBooleanProperties->floatInf);

$this->assertEquals(-\INF, $objectWithBooleanProperties->floatNegInf);

}

private function getDenormalizerForObjectWithBasicProperties()

{

$extractor = $this->createMock(PhpDocExtractor::class);

$extractor->method('getTypes')

->will($this->onConsecutiveCalls(

[new Type('bool')],

[new Type('bool')],

[new Type('bool')],

[new Type('bool')],

[new Type('int')],

[new Type('int')],

[new Type('float')],

[new Type('float')],

[new Type('float')],

[new Type('float')],

[new Type('float')],

[new Type('float')]

));

$denormalizer = new AbstractObjectNormalizerCollectionDummy(null, null, $extractor);

$arrayDenormalizer = new ArrayDenormalizerDummy();

$serializer = new SerializerCollectionDummy([$arrayDenormalizer, $denormalizer]);

$arrayDenormalizer->setSerializer($serializer);

$denormalizer->setSerializer($serializer);

return $denormalizer;

}

public function testDenormalizeBasicTypePropertiesWithStringBoolValues()

{

$denormalizer = $this->getDenormalizerForObjectWithStringBoolValues();

// bool

$objectWithBooleanProperties = $denormalizer->denormalize(

[

'true' => 'true',

'yes' => 'yEs',

'on' => 'ON',

'one' => '1',

'false' => 'falsE',

'no' => 'No',

'off' => 'OfF',

'zero' => '0',

'empty' => '',

],

ObjectWithStringBoolean::class,

null,

[AbstractObjectNormalizer::ENABLE_STRING_BOOL_VALUE => true]

);

$this->assertInstanceOf(ObjectWithStringBoolean::class, $objectWithBooleanProperties);

$this->assertTrue($objectWithBooleanProperties->true);

$this->assertTrue($objectWithBooleanProperties->yes);

$this->assertTrue($objectWithBooleanProperties->on);

$this->assertTrue($objectWithBooleanProperties->one);

$this->assertFalse($objectWithBooleanProperties->false);

$this->assertFalse($objectWithBooleanProperties->no);

$this->assertFalse($objectWithBooleanProperties->off);

$this->assertFalse($objectWithBooleanProperties->zero);

$this->assertFalse($objectWithBooleanProperties->empty);

}

public function testDenormalizeBasicTypePropertiesWithBadStringBoolValues()

{

$denormalizer = $this->getDenormalizerForObjectWithStringBoolValues();

$this->expectException(NotNormalizableValueException::class);

$this->expectExceptionMessage('The value of the "yes" attribute for class "Symfony\Component\Serializer\Tests\Normalizer\ObjectWithStringBoolean" must be one of "true", "yes", "on", "1", "false", "no", "off", "0", "" ("foo" given).');

$objectWithBooleanProperties = $denormalizer->denormalize(

[

'yes' => 'foo',

],

ObjectWithStringBoolean::class,

null,

[AbstractObjectNormalizer::ENABLE_STRING_BOOL_VALUE => true]

);

}

private function getDenormalizerForObjectWithStringBoolValues()

{

$extractor = $this->createMock(PhpDocExtractor::class);

$extractor->method('getTypes')

->will($this->onConsecutiveCalls(

[new Type('bool')],

[new Type('bool')],

[new Type('bool')],

[new Type('bool')],

[new Type('bool')],

[new Type('bool')],

[new Type('bool')],

[new Type('bool')],

[new Type('bool')]

));

$denormalizer = new AbstractObjectNormalizerCollectionDummy(null, null, $extractor);

$arrayDenormalizer = new ArrayDenormalizerDummy();

$serializer = new SerializerCollectionDummy([$arrayDenormalizer, $denormalizer]);

$arrayDenormalizer->setSerializer($serializer);

$denormalizer->setSerializer($serializer);

return $denormalizer;

}

OskarStark · 2021-08-25T06:14:03Z

You can ignore the failing tests from the cache component

aurimasniekis · 2021-09-03T02:03:57Z

Any updates on this?

dunglas · 2021-09-03T05:51:31Z

In my opinion this should be done in the decoder of the specific format having such requirements, as we already do in the YAML decoder.

Converting special strings to bool is not the responsibility of the normalizer.

aurimasniekis · 2021-09-03T05:54:11Z

What if it's not serialized format, but array input. For e.g. trying to denormalize ParameterBag values (which does have the getBoolen method which does exactly this)

dunglas · 2021-09-03T06:30:19Z

Still, it's a niche and non-standard use case that is better handled in another class than the built-in normalizer.

aurimasniekis · 2021-09-03T07:19:46Z

Still, it's a niche and non-standard use case that is better handled in another class than the built-in normalizer.

The issue is to create another normalizer or something I need to clone a whole normalizer because all methods required to tap in are private.

This would be required to make protected, so it could be extended in another normalizer.

symfony/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php

Line 419 in 8e6b1f8

    
           private function validateAndDenormalize(array $types, string $currentClass, string $attribute, $data, ?string $format, array $context)

Otherwise, I would have to maintain an exact copy of AbstractObjectNormalizer which is pointless...

derrabus · 2021-09-03T07:30:53Z

ParameterBag is a class that holds values coming from an HTTP request. I don't think that it's designed to be constructed by anyone but the HttpFoundation component itself. Why is that a denormalization target for you?

aurimasniekis · 2021-09-03T07:35:01Z

ParameterBag is a class that holds values coming from an HTTP request. I don't think that it's designed to be constructed by anyone but the HttpFoundation component itself. Why is that a denormalization target for you?

I have really big and complicated query strings I need to parse and validate, so I passing the query string into the normalizer which fills the object, and then I am using a validator to validate it. This way I have parsed and validated query string params. Sadly I do not have control over the use of query string.

aurimasniekis · 2021-09-03T07:36:49Z

By query string I meant $request->query->all()

aurimasniekis · 2021-09-03T07:45:39Z

One of the reasons why I created this PR as I have mentioned in issue #42715 it is not possible to extend object denormalizer with any custom logic for property values. For which I was able to get around on some other occasions, but on this occasion, I was not able to get around it because of the need to get target property types.

I had made a denormalizer by basically copying AbstractObjectNormalizer but I don't feel it as a good way to make it as it means now I am required to maintain consistency. So I thought it's a good feature and made this PR.

derrabus · 2021-09-03T07:56:56Z

If it's just about validation, you don't need a denormalizer. You could validate the return value of $request->query->all() right away.

The denormalizer is not designed to be used standalone, but as the second step of a two-step deserialization. It operates under the assumption that the input array is created by a decoder that has already taken care of parsing primitive types. What you are basically suggesting is correcting mistakes of the decoding step within the denormalization step.

In your case, the missing piece is something like a QueryStringDecoder that parses the query string and returns the structure expected by the denormalizers (don't take this as a suggestion to implement such a decoder, though).

aurimasniekis · 2021-09-03T08:07:04Z

If it's just about validation, you don't need a denormalizer. You could validate the return value of $request->query->all() right away.

The denormalizer is not designed to be used standalone, but as the second step of a two-step deserialization. It operates under the assumption that the input array is created by a decoder that has already taken care of parsing primitive types. What you are basically suggesting is correcting mistakes of the decoding step within the denormalization step.

In your case, the missing piece is something like a QueryStringDecoder that parses the query string and returns the structure expected by the denormalizers (don't take this as a suggestion to implement such a decoder, though).

I perfectly understand your suggestion, but the problem for this case is not validation, but working with that structure it is nested array type query string, anyway, my main issue here is not about query string, but the inability to extend AbstractObjectAnalyzer with additional denormalization logic for properties.

There is a piece of logic that allows u to handle objects denormalization inside it, and an edge case for handling JSON float values, but no logic to extend for other scalar types.

symfony/src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php

Lines 515 to 524 in 8e6b1f8

    
           if (Type::BUILTIN_TYPE_OBJECT === $builtinType) { 
        
               if (!$this->serializer instanceof DenormalizerInterface) { 
        
                   throw new LogicException(sprintf('Cannot denormalize attribute "%s" for class "%s" because injected serializer is not a denormalizer.', $attribute, $class)); 
        
               } 
        
               $childContext = $this->createChildContext($context, $attribute, $format); 
        
               if ($this->serializer->supportsDenormalization($data, $class, $format, $childContext)) { 
        
                   return $this->serializer->denormalize($data, $class, $format, $childContext); 
        
               } 
        
           }

The easiest way would be to allow extending that method to be extended, or provide adding additional logic for handling scalar types. I had numerous cases where a simple custom denormalizer would have solved a lot of issues even when data is coming from encoders.

OskarStark · 2021-09-03T12:31:31Z

To me this sounds like a dedicated response value object which validates the structure and values of the query string. Afterwards you can work on this kind of object, or am I missing sth. I would not use any de/normalize here

aurimasniekis · 2021-09-03T22:40:40Z

To me this sounds like a dedicated response value object which validates the structure and values of the query string. Afterwards you can work on this kind of object, or am I missing sth. I would not use any de/normalize here

Okay, can we just focus on the extendability of object denormalizer?

dunglas · 2021-09-04T07:17:36Z

@aurimasniekis yes! This is a known issue and there is an ongoing work to refactor this class and make it using composition instead of inheritance. See #30818

fabpot · 2021-10-29T13:48:06Z

Can we take a decision here? @dunglas?

Lappihuan · 2022-03-16T17:05:55Z

i recently stumbled over the same issue and i feel like the biggest issue is, that the AbstractObjectNormalizer is handling scalars and does not delegate to scalar denormalizer/normalizers.
That way a custom denormalizer could be registered to handle such cases.

But regardless, having AbstractObjectNormalizer handle scalars even tho these are handled in their own denormalizer.
#35235

dunglas · 2022-03-18T06:47:25Z

Sorry but I'm in favor of not merging it. The more complexity we add to AbstractObjectNormalizer, the harder it will be to refactor it (which is our main long term goal).

fabpot · 2022-03-18T06:55:56Z

Thank you @dunglas for chiming in. Let's close then.

TerjeBr · 2023-09-14T14:10:24Z

Could you please consider to open this PR again?

The problem is that we want a deserialiser that can handle the arrays that have string values instead of boolean values in some places. This is very useful for data coming form query strings, but also for other sources of data. It is too late to deal with this after deserialisation, because then for example the string "false" has already become a true value. This is exactly the improvement of AbstractObjectNormalizer that we need. Please, please, could you please accept this PR?

skobkin · 2024-06-07T14:04:47Z

Same problem here. Remote system uses query or form data in callbacks. I'm trying to implement a decent wrapper using serializer. It works for outgoing requests when I can use JSON, but doesn't for incoming callbacks where I just can't customize denormalization of bool values.

aurimasniekis requested a review from dunglas as a code owner August 25, 2021 03:39

carsonbot added Status: Needs Review Feature Serializer labels Aug 25, 2021

Added ENABLE_STRING_BOOL_VALUE attribute and logic to Serializer Obje…

8e6b1f8

…ct Normalizer to try parse string boolean values if object attribute type is bool and data value is string using filter_var FILTER_VALIDATE_BOOL function

aurimasniekis mentioned this pull request Aug 25, 2021

[Serializer] Denormalizer doesn't support parsing string value for boolean type or provides a way to extend denormalizer for scalar types #42715

Closed

OskarStark added this to the 5.4 milestone Aug 25, 2021

OskarStark reviewed Aug 25, 2021

View reviewed changes

src/Symfony/Component/Serializer/Tests/Normalizer/AbstractObjectNormalizerTest.php Show resolved Hide resolved

OskarStark reviewed Aug 25, 2021

View reviewed changes

fabpot modified the milestones: 5.4, 6.1 Nov 16, 2021

Merge branch 'symfony:5.4' into 5.4

c7c3d3a

aurimasniekis requested review from chalasr, jderusse, lyrixx, wouterj, xabbuh and yceruto as code owners December 16, 2021 08:46

fabpot closed this Mar 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Serializer] Added functionality to parse string boolean values into object boolean fields on denormalization #42716

[Serializer] Added functionality to parse string boolean values into object boolean fields on denormalization #42716

aurimasniekis commented Aug 25, 2021

aurimasniekis commented Aug 25, 2021 •

edited

Loading

OskarStark Aug 25, 2021

aurimasniekis Aug 25, 2021 •

edited

Loading

OskarStark Aug 25, 2021

aurimasniekis Aug 25, 2021

OskarStark commented Aug 25, 2021

aurimasniekis commented Sep 3, 2021

dunglas commented Sep 3, 2021 •

edited

Loading

aurimasniekis commented Sep 3, 2021

dunglas commented Sep 3, 2021

aurimasniekis commented Sep 3, 2021

derrabus commented Sep 3, 2021

aurimasniekis commented Sep 3, 2021

aurimasniekis commented Sep 3, 2021

aurimasniekis commented Sep 3, 2021

derrabus commented Sep 3, 2021

aurimasniekis commented Sep 3, 2021 •

edited

Loading

OskarStark commented Sep 3, 2021

aurimasniekis commented Sep 3, 2021

dunglas commented Sep 4, 2021

fabpot commented Oct 29, 2021

Lappihuan commented Mar 16, 2022

dunglas commented Mar 18, 2022

fabpot commented Mar 18, 2022

TerjeBr commented Sep 14, 2023

skobkin commented Jun 7, 2024

	throw new NotNormalizableValueException(sprintf('The value of the "%s" attribute for class "%s" must be one of "true", "yes", "on", "1", "false", "no", "off", "0", "" ("%s" given).', $attribute, $currentClass, $data));
	throw new NotNormalizableValueException(sprintf('The value of the "%s" attribute for class "%s" must be one of "true", "yes", "on", "1", "false", "no", "off", "0", ""(empty string) ("%s" given).', $attribute, $currentClass, $data));

	public function testDenormalizeBasicTypePropertiesFromXml()
	{
	$denormalizer = $this->getDenormalizerForObjectWithBasicProperties();

	// bool
	$objectWithBooleanProperties = $denormalizer->denormalize(
	[
	'boolTrue1' => 'true',
	'boolFalse1' => 'false',
	'boolTrue2' => '1',
	'boolFalse2' => '0',
	'int1' => '4711',
	'int2' => '-4711',
	'float1' => '123.456',
	'float2' => '-1.2344e56',
	'float3' => '45E-6',
	'floatNaN' => 'NaN',
	'floatInf' => 'INF',
	'floatNegInf' => '-INF',
	],
	ObjectWithBasicProperties::class,
	'xml'
	);

	$this->assertInstanceOf(ObjectWithBasicProperties::class, $objectWithBooleanProperties);

	// Bool Properties
	$this->assertTrue($objectWithBooleanProperties->boolTrue1);
	$this->assertFalse($objectWithBooleanProperties->boolFalse1);
	$this->assertTrue($objectWithBooleanProperties->boolTrue2);
	$this->assertFalse($objectWithBooleanProperties->boolFalse2);

	// Integer Properties
	$this->assertEquals(4711, $objectWithBooleanProperties->int1);
	$this->assertEquals(-4711, $objectWithBooleanProperties->int2);

	// Float Properties
	$this->assertEqualsWithDelta(123.456, $objectWithBooleanProperties->float1, 0.01);
	$this->assertEqualsWithDelta(-1.2344e56, $objectWithBooleanProperties->float2, 1);
	$this->assertEqualsWithDelta(45E-6, $objectWithBooleanProperties->float3, 1);
	$this->assertNan($objectWithBooleanProperties->floatNaN);
	$this->assertInfinite($objectWithBooleanProperties->floatInf);
	$this->assertEquals(-\INF, $objectWithBooleanProperties->floatNegInf);
	}

	private function getDenormalizerForObjectWithBasicProperties()
	{
	$extractor = $this->createMock(PhpDocExtractor::class);
	$extractor->method('getTypes')
	->will($this->onConsecutiveCalls(
	[new Type('bool')],
	[new Type('bool')],
	[new Type('bool')],
	[new Type('bool')],
	[new Type('int')],
	[new Type('int')],
	[new Type('float')],
	[new Type('float')],
	[new Type('float')],
	[new Type('float')],
	[new Type('float')],
	[new Type('float')]
	));

	$denormalizer = new AbstractObjectNormalizerCollectionDummy(null, null, $extractor);
	$arrayDenormalizer = new ArrayDenormalizerDummy();
	$serializer = new SerializerCollectionDummy([$arrayDenormalizer, $denormalizer]);
	$arrayDenormalizer->setSerializer($serializer);
	$denormalizer->setSerializer($serializer);

	return $denormalizer;
	}

	public function testDenormalizeBasicTypePropertiesWithStringBoolValues()
	{
	$denormalizer = $this->getDenormalizerForObjectWithStringBoolValues();

	// bool
	$objectWithBooleanProperties = $denormalizer->denormalize(
	[
	'true' => 'true',
	'yes' => 'yEs',
	'on' => 'ON',
	'one' => '1',
	'false' => 'falsE',
	'no' => 'No',
	'off' => 'OfF',
	'zero' => '0',
	'empty' => '',
	],
	ObjectWithStringBoolean::class,
	null,
	[AbstractObjectNormalizer::ENABLE_STRING_BOOL_VALUE => true]
	);

	$this->assertInstanceOf(ObjectWithStringBoolean::class, $objectWithBooleanProperties);

	$this->assertTrue($objectWithBooleanProperties->true);
	$this->assertTrue($objectWithBooleanProperties->yes);
	$this->assertTrue($objectWithBooleanProperties->on);
	$this->assertTrue($objectWithBooleanProperties->one);
	$this->assertFalse($objectWithBooleanProperties->false);
	$this->assertFalse($objectWithBooleanProperties->no);
	$this->assertFalse($objectWithBooleanProperties->off);
	$this->assertFalse($objectWithBooleanProperties->zero);
	$this->assertFalse($objectWithBooleanProperties->empty);
	}

	public function testDenormalizeBasicTypePropertiesWithBadStringBoolValues()
	{
	$denormalizer = $this->getDenormalizerForObjectWithStringBoolValues();

	$this->expectException(NotNormalizableValueException::class);
	$this->expectExceptionMessage('The value of the "yes" attribute for class "Symfony\Component\Serializer\Tests\Normalizer\ObjectWithStringBoolean" must be one of "true", "yes", "on", "1", "false", "no", "off", "0", "" ("foo" given).');

	$objectWithBooleanProperties = $denormalizer->denormalize(
	[
	'yes' => 'foo',
	],
	ObjectWithStringBoolean::class,
	null,
	[AbstractObjectNormalizer::ENABLE_STRING_BOOL_VALUE => true]
	);
	}

	private function getDenormalizerForObjectWithStringBoolValues()
	{
	$extractor = $this->createMock(PhpDocExtractor::class);
	$extractor->method('getTypes')
	->will($this->onConsecutiveCalls(
	[new Type('bool')],
	[new Type('bool')],
	[new Type('bool')],
	[new Type('bool')],
	[new Type('bool')],
	[new Type('bool')],
	[new Type('bool')],
	[new Type('bool')],
	[new Type('bool')]
	));

	$denormalizer = new AbstractObjectNormalizerCollectionDummy(null, null, $extractor);
	$arrayDenormalizer = new ArrayDenormalizerDummy();
	$serializer = new SerializerCollectionDummy([$arrayDenormalizer, $denormalizer]);
	$arrayDenormalizer->setSerializer($serializer);
	$denormalizer->setSerializer($serializer);

	return $denormalizer;
	}

[Serializer] Added functionality to parse string boolean values into object boolean fields on denormalization #42716

[Serializer] Added functionality to parse string boolean values into object boolean fields on denormalization #42716

Conversation

aurimasniekis commented Aug 25, 2021

aurimasniekis commented Aug 25, 2021 • edited Loading

OskarStark Aug 25, 2021

Choose a reason for hiding this comment

aurimasniekis Aug 25, 2021 • edited Loading

Choose a reason for hiding this comment

OskarStark Aug 25, 2021

Choose a reason for hiding this comment

aurimasniekis Aug 25, 2021

Choose a reason for hiding this comment

OskarStark commented Aug 25, 2021

aurimasniekis commented Sep 3, 2021

dunglas commented Sep 3, 2021 • edited Loading

aurimasniekis commented Sep 3, 2021

dunglas commented Sep 3, 2021

aurimasniekis commented Sep 3, 2021

derrabus commented Sep 3, 2021

aurimasniekis commented Sep 3, 2021

aurimasniekis commented Sep 3, 2021

aurimasniekis commented Sep 3, 2021

derrabus commented Sep 3, 2021

aurimasniekis commented Sep 3, 2021 • edited Loading

OskarStark commented Sep 3, 2021

aurimasniekis commented Sep 3, 2021

dunglas commented Sep 4, 2021

fabpot commented Oct 29, 2021

Lappihuan commented Mar 16, 2022

dunglas commented Mar 18, 2022

fabpot commented Mar 18, 2022

TerjeBr commented Sep 14, 2023

skobkin commented Jun 7, 2024

aurimasniekis commented Aug 25, 2021 •

edited

Loading

aurimasniekis Aug 25, 2021 •

edited

Loading

dunglas commented Sep 3, 2021 •

edited

Loading

aurimasniekis commented Sep 3, 2021 •

edited

Loading