[VarExporter] Suppress deprecations for legacy fixtures #42782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25f6233 to
01dcc62
Compare
Tobion
approved these changes
Aug 30, 2021
chalasr
approved these changes
Aug 30, 2021
|
I suggest adding a comment in the code explaining what is done there (that's not self-explanatory right now), which will also allow figuring out that this can be removed once the min PHP requirement allows us to stop caring about that special case. |
Will do.
That'll be PHP 9 then. 😱 |
Signed-off-by: Alexander M. Turek <me@derrabus.de>
01dcc62 to
2db2c00
Compare
|
I've added a longer comment to the custom error handling that should explain what I'm doing. |
stof
approved these changes
Aug 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two test fixtures currently trigger a deprecation on PHP 8.1 because they implement
Serializablewithout implementing__serialize()and__unserialize(). However, I believe that we want to test the behavior of the component with this kind of implementation. This why I decided to suppress the deprecation instead of upgrading the fixtures.