[DependencyInjection] Fix circular reference in autowired decorators #42815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyim
commented
Aug 31, 2021
| try { | ||
| (new AutowirePass())->process($container); | ||
| $this->fail('AutowirePass should have thrown an exception'); | ||
| } catch (AutowiringFailedException $e) { | ||
| $this->assertSame('Cannot autowire service "Symfony\Component\DependencyInjection\Tests\Compiler\NonAutowirableDecorator": argument "$decorated1" of method "__construct()" references interface "Symfony\Component\DependencyInjection\Tests\Compiler\DecoratorInterface" but no such service exists. You should maybe alias this interface to one of these existing services: "Symfony\Component\DependencyInjection\Tests\Compiler\NonAutowirableDecorator", "Symfony\Component\DependencyInjection\Tests\Compiler\NonAutowirableDecorator.inner".', (string) $e->getMessage()); | ||
| $this->assertSame('Cannot autowire service "Symfony\Component\DependencyInjection\Tests\Compiler\NonAutowirableDecorator": argument "$decorated1" of method "__construct()" references interface "Symfony\Component\DependencyInjection\Tests\Compiler\DecoratorInterface" but no such service exists. You should maybe alias this interface to one of these existing services: "Symfony\Component\DependencyInjection\Tests\Compiler\Decorated", "Symfony\Component\DependencyInjection\Tests\Compiler\NonAutowirableDecorator".', (string) $e->getMessage()); |
There was a problem hiding this comment.
Is that so okay? As the DecoratorPass did not run until this point the .inner does not exists yet 😅
|
The fabbot wants unreleated change which looks wrong 😅 |
derrabus
approved these changes
Aug 31, 2021
src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
Outdated
Show resolved
Hide resolved
jderusse
reviewed
Aug 31, 2021
src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
Outdated
Show resolved
Hide resolved
dunglas
approved these changes
Aug 31, 2021
jderusse
approved these changes
Aug 31, 2021
fabpot
approved these changes
Sep 1, 2021
|
Thank you @shyim. |
|
Just to be sure: will there be a version 5.3.8 with this fix before 5.4? ATM we are unable to update to 5.3.7 due to this error. |
|
yes |
Merged
Okhoshi
added a commit
to Okhoshi/symfony
that referenced
this pull request
Oct 19, 2021
Okhoshi
added a commit
to Okhoshi/symfony
that referenced
this pull request
Oct 19, 2021
Okhoshi
added a commit
to Okhoshi/symfony
that referenced
this pull request
Oct 19, 2021
Okhoshi
added a commit
to Okhoshi/symfony
that referenced
this pull request
Oct 19, 2021
Okhoshi
added a commit
to Okhoshi/symfony
that referenced
this pull request
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the Decorator pass runs after the Autowire, the
innerServiceIdwas always empty. I have changed that togetDecoratedServiceand added a test with the given example in the issue.