Fix tests failing with DBAL 3 #42819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd prefer to ignore fabbot's suggestion if that's okay. |
d3072e6 to
45b011e
Compare
derrabus
commented
Aug 31, 2021
| $stmt = $this->getConnection()->prepare($sql); | ||
| $stmt->bindValue($i = 1, $now, \PDO::PARAM_INT); | ||
| $stmt = $connection->prepare($sql); | ||
| $stmt->bindValue($i = 1, $now, $useDbalConstants ? ParameterType::INTEGER : \PDO::PARAM_INT); |
There was a problem hiding this comment.
Using the PDO constants on a DBAL 3 connection will break in PHP 8.1 because PDO changed the values of those constants. 😱
45b011e to
5ee3ad4
Compare
Tobion
reviewed
Sep 1, 2021
src/Symfony/Bridge/Doctrine/Tests/DataCollector/DoctrineDataCollectorTest.php
Outdated
Show resolved
Hide resolved
OskarStark
approved these changes
Sep 1, 2021
src/Symfony/Bridge/Doctrine/Tests/Messenger/DoctrinePingConnectionMiddlewareTest.php
Show resolved
Hide resolved
stof
reviewed
Sep 1, 2021
src/Symfony/Bridge/Doctrine/Security/RememberMe/DoctrineTokenProvider.php
Outdated
Show resolved
Hide resolved
23f9649 to
784d948
Compare
fabpot
approved these changes
Sep 1, 2021
784d948 to
3ce1f76
Compare
|
Thank you @derrabus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doctrine ORM is not blocking the installation of DBAL 3 anymore. This has revealed a few tests that were not fully compatible with DBAL 3. This PR is an attempt to fix them.