[HttpKernel] Remove time-sensitivity from InlineFragmentRendererTest
#42824
Conversation
|
Is there a better way to compare ignoring parts? This is the best I could come up with.. |
|
Strange, I don't understand why the 7.4 high-deps test would still fail comparing those responses. I tested locally with a sleep to be sure this works 🤔 Update: this must be because of how the high-deps work which I did not fully understand yet.. Would be great if exactly that error is not happening any more after this PR got merged. Update2: I think I got it now. The high-deps mean in this context that checks are done with my branch as dependency using Symfony 3.4. So even if this PR gets merged, the high-deps CI job for 4.4 PRs might still make problems hmm. |
0428e66 to
70e1bc0
Compare
|
Any idea why these tests fail? Does that follow a recent PR? |
no clue unfortunately, I did not further look into it. I just saw that failure in 4.4 PRs and thought "oh, something time-sensitive, let's fix it" :/ |
70e1bc0 to
b5831b6
Compare
This PR was merged into the 4.4 branch. Discussion ---------- [HttpKernel] Relax some transient tests | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - As observed in #42824 and more recently #43138, these tests randomly break for some reason. Replaces #42824 Commits ------- 30fa29f [HttpKernel] Relax some transient tests
|
Closing in favor of #43264. Thank you for the PR. |
I noticed this test failing in #42823 and this is my attempt to remove the time-sensitivity there.