[Mime] Update mime types #42831
Merged
[Mime] Update mime types #42831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Sep 1, 2021
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | n/a |
| License | MIT |
| Doc PR | symfony/symfony-docs#... |
fabpot
commented
Sep 1, 2021
ef41dfa to
8ce5533
Compare
derrabus
approved these changes
Sep 1, 2021
OskarStark
approved these changes
Sep 2, 2021
|
Thank you Fabien. |
|
@fabpot Apparently, the list of MIME types has been changed on 5.3 in the past and I'm a bit clueless how to merge your changes to 4.4 up to 5.3. Can you please have a look? |
|
Shouldn't we merge such changes in 5.4? |
|
Arf, I've been caught at my own game. I'm the one advocating more merges in the main branch, and I've submitted this one on 4.4. My bad. I will revert on 4.4 and submit one on 5.4 instead. |
fabpot
added a commit
that referenced
this pull request
Sep 3, 2021
* 4.4: Revert "bug #42831 [Mime] Update mime types (fabpot)" Fix implicit float to int cast [Mime] Update mime types [HttpKernel] Fix timeline in profiler
fabpot
added a commit
that referenced
this pull request
Sep 3, 2021
* 5.3: Revert "bug #42831 [Mime] Update mime types (fabpot)" Clean about command description after Environment section was removed Fix implicit float to int cast [Mime] Update mime types [HttpKernel] Fix timeline in profiler
|
See #42872 |
derrabus
added a commit
that referenced
this pull request
Sep 3, 2021
* 5.4: Revert "bug #42831 [Mime] Update mime types (fabpot)" Clean about command description after Environment section was removed Fix implicit float to int cast [Mime] Update mime types [HttpKernel] Fix timeline in profiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.