Skip to content

[Security] Relax return type on VoterInterface #42901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2021
Merged

[Security] Relax return type on VoterInterface #42901

merged 1 commit into from
Sep 7, 2021

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Sep 6, 2021

Q A
Branch? 6.0
Bug fix? no
New feature? no
Deprecations? no
Tickets symfony/security-acl#97 (comment)
License MIT
Doc PR N/A

@carsonbot carsonbot added this to the 6.0 milestone Sep 6, 2021
@derrabus derrabus mentioned this pull request Sep 6, 2021
Closed
@nicolas-grekas
Copy link
Member

You shall also update .github/expected-missing-return-types.diff

@derrabus derrabus force-pushed the improvement/relax-voter-interface branch from d3e6a59 to 9387f9c Compare September 6, 2021 17:30
@derrabus
Copy link
Member Author

derrabus commented Sep 6, 2021

You shall also update .github/expected-missing-return-types.diff

I see. 🙈

@derrabus derrabus force-pushed the improvement/relax-voter-interface branch from 9387f9c to c91712c Compare September 6, 2021 17:44
@fabpot
Copy link
Member

fabpot commented Sep 7, 2021

Thank you @derrabus.

@fabpot fabpot merged commit 41b726f into symfony:6.0 Sep 7, 2021
@derrabus derrabus deleted the improvement/relax-voter-interface branch September 7, 2021 05:40
@nicolas-grekas
Copy link
Member

Linking to #43021 for history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@wouterj wouterj wouterj approved these changes

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@derrabus @nicolas-grekas @fabpot @wouterj @carsonbot