[Cache] Make sure PdoAdapter::prune() always returns a bool #42904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this should be fine for 4.4 |
fabpot
approved these changes
Sep 7, 2021
|
Can you rebase on 4.4 then? |
8b3a1df to
abad7cf
Compare
Signed-off-by: Alexander M. Turek <me@derrabus.de>
abad7cf to
b8ddb65
Compare
|
Done! I've also adjusted |
|
Thank you @derrabus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a failing test on the 6.0 branch.
I wasn't sure if I should backport this change to 4.4/5.3 since the behavior of returning a DBAL result has always been wrong, kinda.Backported!