Skip to content

[Messenger] Support rediss in transport bridge #42932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2021
Merged

[Messenger] Support rediss in transport bridge #42932

merged 1 commit into from
Sep 8, 2021

Conversation

RuslanZavacky
Copy link
Contributor

@RuslanZavacky RuslanZavacky commented Sep 8, 2021 •
edited by nicolas-grekas
Loading

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR

Seems like support for rediss was added in the main package, but didn't propagate to the bridge

Followed a trail from here - #39607

@RuslanZavacky RuslanZavacky requested a review from sroze as a code owner September 8, 2021 11:26
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@RuslanZavacky RuslanZavacky changed the base branch from 5.4 to 5.3 September 8, 2021 11:27
@RuslanZavacky RuslanZavacky changed the base branch from 5.3 to 5.4 September 8, 2021 11:27
@RuslanZavacky
Copy link
Contributor Author

Feels like I might've opened it to the wrong initial branch, probably the lowest should be as 5.3, if that's the case, let me know and I can redo this one :)

@RuslanZavacky
Copy link
Contributor Author

Test failure doesn't seem to be relevant, or I am missing something?

@carsonbot carsonbot changed the title Support rediss in transport bridge [Messenger] Support rediss in transport bridge Sep 8, 2021
nicolas-grekas
nicolas-grekas approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(for 5.3)

@nicolas-grekas nicolas-grekas added this to the 5.3 milestone Sep 8, 2021
@nicolas-grekas nicolas-grekas changed the base branch from 5.4 to 5.3 September 8, 2021 16:56
@nicolas-grekas nicolas-grekas force-pushed the support-rediss-in-transport-bridge branch from ce7dceb to edfad64 Compare September 8, 2021 16:56
@nicolas-grekas
Copy link
Member

Thank you @RuslanZavacky.

@nicolas-grekas nicolas-grekas merged commit 3cf8234 into symfony:5.3 Sep 8, 2021
@fabpot fabpot mentioned this pull request Sep 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@sroze sroze Awaiting requested review from sroze

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@jderusse jderusse Awaiting requested review from jderusse

@lyrixx lyrixx Awaiting requested review from lyrixx

@OskarStark OskarStark Awaiting requested review from OskarStark

@wouterj wouterj Awaiting requested review from wouterj

@xabbuh xabbuh Awaiting requested review from xabbuh

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
Bug Messenger Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@RuslanZavacky @carsonbot @nicolas-grekas