[ErrorHandler] Reword return type deprecation message #42935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
derrabus
reviewed
Sep 8, 2021
10ea722 to
09c84bc
Compare
|
Thanks @derrabus. I have no clue where the Psalm errors come from... |
Apparently, we need to install PhpUnitBridge before running Psalm. 🤔 |
|
But it doesn't show up in e.g. #42939 . So it must be that the changes in this PR cause Psalm to fail with these errors? |
It is triggered for all classes (not only Symfony-ones), so we cannot be precise on when it will be added. However, we must do a "call to action" to prepare users for Symfony 6 (and potentially other package releases).
09c84bc to
b7d88cf
Compare
|
Thank you @wouterj. |
nicolas-grekas
added a commit
that referenced
this pull request
Sep 30, 2021
…r missing return types on 5.3 (chalasr) This PR was merged into the 5.3 branch. Discussion ---------- [PhpUnitBridge] Fix skipping triggering file override for missing return types on 5.3 | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | - | Tickets | - | License | MIT | Doc PR | - #43241 was merged in 5.3 instead of 5.4, but the deprecation notice was reworded on 5.4: #42935. Commits ------- c1034dc [PHPUnitBridge] Fix skipping triggering file override on 5.3
symfony-splitter
pushed a commit
to symfony/phpunit-bridge
that referenced
this pull request
Sep 30, 2021
…r missing return types on 5.3 (chalasr) This PR was merged into the 5.3 branch. Discussion ---------- [PhpUnitBridge] Fix skipping triggering file override for missing return types on 5.3 | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | yes | New feature? | no | Deprecations? | - | Tickets | - | License | MIT | Doc PR | - symfony/symfony#43241 was merged in 5.3 instead of 5.4, but the deprecation notice was reworded on 5.4: symfony/symfony#42935. Commits ------- c1034dc940 [PHPUnitBridge] Fix skipping triggering file override on 5.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deprecation is triggered for all classes (not only Symfony-ones), so we cannot be precise on when it will be added. However, we must do a "call to action" to prepare users for Symfony 6 (and potentially other package releases).
I do welcome suggestions for better wordings :) (i.e. is "php return type" clear?)