Implement Message Stream for Postmark Mailer #42941
Conversation
|
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
|
There seem to be some code style issues but fabbot.io doesn't say what they are. |
|
I accidentally set "deprecations" to yes instead of no so carsonbot marked this PR as such, sorry. |
|
Dries, we removed the |
|
@driesvints You can click on |
|
I don't see a Preview button. |
|
It seems like I can't read it says |
|
@Jubeki ah wow, totally missed that. I was clicking the red "3" all the time 😅 Thanks, got those fixed |
|
Unsure why the AppVeyor build is failing. I can't see any failing tests but it's a little hard to digest with all the separate runs for the different components. |
|
@driesvints as I can see, this is related to maximum build time exceeded (20 minutes) - https://ci.appveyor.com/project/fabpot/symfony/builds/40692324/messages I think this fail should be skipped |
src/Symfony/Component/Mailer/Bridge/Postmark/Transport/PostmarkApiTransport.php
Show resolved
Hide resolved
|
Thank you @driesvints. |
This PR provide's support for Postmark's separate Message Stream feature in both the API and SMTP transports. I've added the ability to both add a default Message Stream for the entire transport as well as specific message streams per email.
Right now in Laravel users have the ability to define a default Message Stream per transport through the wildbit/swiftmailer-postmark package. But unfortunately Symfony Mailer, which we're switching to for the upcoming Laravel v9 release doesn't has this feature yet. That's why we decided to send in this PR so both Symfony and Laravel users can enjoy this feature from Postmark. This PR is needed for laravel/framework#38481
I've added a new
MessageStreamHeaderspecifically for Postmark because it's a Postmark specific feature.Documentation for SMTP can be found here: https://postmarkapp.com/support/article/1207-how-to-create-and-send-through-message-streams
Documentation for API can be found here: https://postmarkapp.com/developer/api/email-api
Current setup through Laravel can be found here: https://laravel.com/docs/8.x/mail#postmark-driver
Another example is Mailcoach by Spatie: https://spatie.be/docs/laravel-mailcoach/v4/configuring-mail-providers/postmark#setting-the-message-stream-in-your-laravel-app