[RateLimiter][Runtime][Translation] remove @experimental flag
#42957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Sep 9, 2021
That sentence ("Once the authenticator system is no longer experimental, this class can be used to trigger deprecation notices.") can be removed. We decided not to add a deprecation notice there, as it was already covered by other deprecation notices about the old authentication system. |
32c6b3f to
a98edfd
Compare
|
Thanks for the hint. PR is ready. |
wouterj
approved these changes
Sep 10, 2021
fabpot
added a commit
that referenced
this pull request
Sep 15, 2021
…d (Jean-Beru) This PR was merged into the 5.4 branch. Discussion ---------- [RateLimiter][Runtime] Remove experimental from README.md | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | <!-- required for new features --> Since #42957 is merged, experimental mentions in RateLimiter and Runtime README.md files can be removed. Commits ------- 012d328 [RateLimiter][Runtime] Remove experimental from README.md
symfony-splitter
pushed a commit
to symfony/runtime
that referenced
this pull request
Sep 15, 2021
…d (Jean-Beru) This PR was merged into the 5.4 branch. Discussion ---------- [RateLimiter][Runtime] Remove experimental from README.md | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | <!-- required for new features --> Since symfony/symfony#42957 is merged, experimental mentions in RateLimiter and Runtime README.md files can be removed. Commits ------- 012d3286d2 [RateLimiter][Runtime] Remove experimental from README.md
symfony-splitter
pushed a commit
to symfony/rate-limiter
that referenced
this pull request
Sep 15, 2021
…d (Jean-Beru) This PR was merged into the 5.4 branch. Discussion ---------- [RateLimiter][Runtime] Remove experimental from README.md | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no <!-- please update src/**/CHANGELOG.md files --> | Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tickets | <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead --> | License | MIT | Doc PR | <!-- required for new features --> Since symfony/symfony#42957 is merged, experimental mentions in RateLimiter and Runtime README.md files can be removed. Commits ------- 012d3286d2 [RateLimiter][Runtime] Remove experimental from README.md
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @wouterj there is a note in
src/Symfony/Component/Security/Http/Authentication/NoopAuthenticationManager.phpthat some cleanup is needed now, can you please have a look?