[ErrorHandler] Add helper script to patch type declarations #42988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6364d3c to
1a799e1
Compare
|
Hey! I think @fancyweb has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
src/Symfony/Component/ErrorHandler/Resources/bin/patch-type-declarations
Outdated
Show resolved
Hide resolved
src/Symfony/Component/ErrorHandler/Resources/bin/patch-type-declarations.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/ErrorHandler/Resources/bin/patch-type-declarations.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/ErrorHandler/Resources/bin/patch-type-declarations.php
Outdated
Show resolved
Hide resolved
0f8b7c1 to
8311f21
Compare
|
PR updated, including the proposed changes. Also added some help information, and added a basic deprecation handling (I don't want to depend on PhpUnitBridge - but it's still good to show type deprecations imho). |
nicolas-grekas
approved these changes
Sep 13, 2021
src/Symfony/Component/ErrorHandler/Resources/bin/patch-type-declarations
Outdated
Show resolved
Hide resolved
src/Symfony/Component/ErrorHandler/Resources/bin/patch-type-declarations
Outdated
Show resolved
Hide resolved
8311f21 to
4467659
Compare
4467659 to
9e6da7e
Compare
derrabus
approved these changes
Sep 13, 2021
|
Thank you Wouter. |
wouterj
added a commit
to symfony/symfony-docs
that referenced
this pull request
Sep 13, 2021
…ugClassLoader (wouterj) This PR was merged into the 5.4 branch. Discussion ---------- [5.4] Document the patch type functionality of the DebugClassLoader This is a critical bit of functionality that we have to explain before the stabilization phase, in order to document for open source maintainers how to make their packages compatible with Symfony 6. When 6.0 is released, it is also an important feature to smooth upgrading for application users. This is why the main text focuses on application, and I added a special sidebar for OSS maintainers. I wasn't sure about the location for this functionality, but I think it makes most sense in the "upgrade major" article (although it used to be a very generic document). `@nicolas`-grekas and `@derrabus` as far as I know, you two have been most involved in this process. Please, if you have time, validate that feature is described correctly and that the "Recommended approach for OSS maintainers" is actually the recommended one :D --- Ref symfony/symfony#42988 Commits ------- fbf0adf Document DebugClassLoader type patch functionality
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying out the patch functionality in my bundle (and simultaneously writing docs for it), I found that I would pretty much recommend to copy-paste the
.github/patch-types.phpscript. So I made it a bit more generic and added it as an official script to the ErrorHandler component.Usage:
For reference: I did not remove the
.github/patch-type.phpscript. I don't think it's worth replacing all the exclusion rules in that script with a single regex.@nicolas-grekas please let me know if you think this makes sense (or if I'm interpreting the new functionality completely wrong).