[FrameworkBundle] Add configureContainer(), configureRoutes() and getConfigDir() to MicroKernelTrait #42991
Conversation
9b735f1 to
89298b9
Compare
| @@ -152,7 +185,7 @@ public function registerContainerConfiguration(LoaderInterface $loader) | |||
| }; | |||
|
|
|||
| try { | |||
| $this->configureContainer(new ContainerConfigurator($container, $kernelLoader, $instanceof, $file, $file, $this->getEnvironment()), $loader); | |||
| $configureContainer->getClosure($this)(new ContainerConfigurator($container, $kernelLoader, $instanceof, $file, $file, $this->getEnvironment()), $loader, $container); | |||
There was a problem hiding this comment.
3rd argument to help with #35554
|
I like it 👍🏼 |
…ConfigDir() to MicroKernelTrait
89298b9 to
8914529
Compare
|
Please give me another day or two to test and review this carefully. |
|
@nicolas-grekas why |
|
Method from traits can be overridden in the class that uses the trait even if they are private. |
|
🤦 thank you @nicolas-grekas |
This PR aims at moving code from the Kernel's recipe to
MicroKernelTrait.It has also the benefit of not requiring ppl that don't use the router to still implement
configureRoutes()in their app.