[Serializer] Throw NotNormalizableValueException when type is not known or not in body in discriminator map #43004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wn or not in body in discriminator map
|
Hey! I think @mkrauser has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
chalasr
approved these changes
Sep 21, 2021
fabpot
approved these changes
Sep 21, 2021
|
Thank you @lyrixx. |
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found another case where the API could leak internal and throw 500
when a user submit invalid values
Note: I have to tweak a bit an exception message