[HttpFoundation] Map multipart/form-data as form Content-Type
#43017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't find many tests If there's any other test that I've missed, please let me know and I'll update it accordingly. |
|
The failing test seems unrelated to this PR. |
derrabus
approved these changes
Sep 14, 2021
|
We're trying to be on the more cautious side to judge whether something is a bug or a feature since some time. So I would say this "bug fixing feature" should target 5.4. |
As per RFC 2045 and RFC 2388, the `multipart/form-data` Content-Type should be used when submitting a mixed form containing files, binary data and non-ASCII data. This commit helps with infrastructure that is directly checking against the `Request::getContentType()` method in scenarios, where a mixed form has been submitted. Resolves symfony#34240
db4d779 to
e597655
Compare
|
@wouterj I've rebased the PR to 5.4 as requested. Thanks for the feedback to both of you |
yceruto
approved these changes
Sep 14, 2021
fabpot
approved these changes
Sep 19, 2021
|
Thank you @keichinger. |
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per RFC 2045 and RFC 2388 (see https://www.w3.org/TR/html401/interact/forms.html#h-17.13.4.2), the
multipart/form-dataContent-Type should be used when submitting a mixed forms containing files, binary data and non-ASCII data.Currently, the same logic that would run in regular, non-mixed form scenarios can't run for mixed forms, as soon as it relies on the result of
Request::getContentType()or anything else that might rely onRequest::$formatswithout going low-level and avoiding the implemented abstraction. This PR fixes that.Resolves #34240