Skip to content

[Notifier] [Firebase] Only call setMessageId if valid message id #43097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Notifier] [Firebase] Only call setMessageId if valid message id #43097

wants to merge 1 commit into from

Conversation

OskarStark
Copy link
Contributor

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Follows #43073 (comment)
License MIT
Doc PR ---

@OskarStark OskarStark self-assigned this Sep 19, 2021
@carsonbot carsonbot added this to the 5.3 milestone Sep 19, 2021
@carsonbot carsonbot changed the title [Notifier][Firebase] Only call setMessageId if valid message id [Notifier] [Firebase] Only call setMessageId if valid message id Sep 19, 2021
@OskarStark OskarStark requested a review from fabpot September 19, 2021 19:56
@fabpot
Copy link
Member

fabpot commented Sep 20, 2021

As I expect that most the time we will have a message id, I don't think this is needed.

@OskarStark OskarStark closed this Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noniagriconomie noniagriconomie noniagriconomie left review comments

@fabpot fabpot Awaiting requested review from fabpot

Assignees

@OskarStark OskarStark

Labels
Bug Notifier Status: Needs Review
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
4 participants
@OskarStark @fabpot @noniagriconomie @carsonbot