[HttpKernel] Add basic support for language negotiation #43108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for taking over :-) |
|
Using the |
stof
reviewed
Sep 20, 2021
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Show resolved
Hide resolved
d491c3b to
9f0e400
Compare
dunglas
requested changes
Sep 20, 2021
75e8338 to
456df0f
Compare
stof
reviewed
Sep 20, 2021
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpKernel/EventListener/ResponseListener.php
Outdated
Show resolved
Hide resolved
53f82a0 to
59317c0
Compare
|
This PR is ready. |
dunglas
approved these changes
Oct 5, 2021
src/Symfony/Component/HttpKernel/EventListener/LocaleListener.php
Outdated
Show resolved
Hide resolved
derrabus
approved these changes
Oct 5, 2021
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
Outdated
Show resolved
Hide resolved
|
Thanks for the reviews! All fixed now |
|
Thank you @GregoireHebert and @chalasr. |
javiereguiluz
added a commit
to symfony/symfony-docs
that referenced
this pull request
Oct 19, 2021
…(hiddewie) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [HttpKernel] Add basic support for language negotiation From symfony/symfony#43108 Fixes #15891 I moved the documentation for the deprecated option with a deprecation notice at the old place. The new options `set_content_language_from_locale` and `set_locale_from_accept_language` have been documented. Commits ------- c41db2f [HttpKernel] Add basic support for language negotiation
This was referenced Nov 5, 2021
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Dec 1, 2021
…rs (maxhelias) This PR was merged into the 5.4 branch. Discussion ---------- [FrameworkBundle] ResponseListener needs only 2 parameters | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | - | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Introduced in 5.4 with : #43108 Commits ------- 6074226 ResponseListener needs only 2 parameters
fabpot
added a commit
that referenced
this pull request
Dec 1, 2021
…riate (nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [HttpKernel] fix sending Vary: Accept-Language when appropriate | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - That's something I figured our while reviewing #44386 and that we missed in #43108: the `Vary` header should be sent when we use `Accept-Language`, not when we send `Content-Language`. /cc @chalasr Commits ------- afab34d [HttpKernel] fix sending Vary: Accept-Language when appropriate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #36507. Thanks @GregoireHebert!
This PR adds two options to the framework configuration:
set_locale_from_accept_language: Makes theRequest' locale automatically set based on theAccept-Languageheader (restricted by a newframework.enabled_localesconfig option which replacesframework.translator.enabled_locales).The explicit
_localerequest attribute always wins over theAccept-Languageheader when it's set.set_content_language_from_locale: Sets theContent-LanguageResponse header based on theRequest' locale.This is going to be useful for API Platform and related (e.g. Sylius/Sylius#11412).