[Messenger] [Redis] Allow authentication with user and password #43124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is 4.4 affected by this bug as well? |
jderusse
reviewed
Sep 21, 2021
src/Symfony/Component/Messenger/Bridge/Redis/Transport/Connection.php
Outdated
Show resolved
Hide resolved
File did not exists in 4.4 ! |
jderusse
approved these changes
Sep 21, 2021
chalasr
approved these changes
Sep 22, 2021
That was not my question. 😉 Messenger 4.4 did have support for Redis and the logic was eventually moved to the file you're fixing here. |
|
I suppose the code was in |
|
Ok, my bad! should backport the PR to 4.4 as well @fabpot ? |
|
Please rebase on 4.4 and do the change on that file, yes. We will take care of applying the patch to the new location when merging up. |
9340f36 to
378126a
Compare
|
@chalasr I've changed the base branch & files :) |
derrabus
approved these changes
Sep 24, 2021
e8a034e to
5a6bf50
Compare
|
Thank you @GaryPEGEOT. |
chalasr
added a commit
that referenced
this pull request
Oct 24, 2021
…llfa) This PR was merged into the 4.4 branch. Discussion ---------- [Messenger] Fix Redis Transport when username is empty | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #43306 | License | MIT | Doc PR | n/a Checking the username and the password with `isset` is not enough. We also need to check they're not empty strings. This fixes the BC break introduced by #43124. See also https://3v4l.org/iASnE Commits ------- cd66b8c [Messenger] Fix Redis Transport when username is empty
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to authenticate on Redis with user and password, instead of only password