Skip to content

[FrameworkBundle] Avoid secrets:decrypt-to-local command to fail #43137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2021
Merged

[FrameworkBundle] Avoid secrets:decrypt-to-local command to fail #43137

merged 1 commit into from
Sep 24, 2021

Conversation

94noni
Copy link
Contributor

@94noni 94noni commented Sep 22, 2021 •
edited
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #42038
License MIT
Doc PR .

Small PR to fix this issue I encounter as well
For now I've not opted for solutions exposed in the issue, please discuss here

Also, I kept the vault continuing instead of stopping the command in case of null value

Thank you,

@carsonbot carsonbot added this to the 5.3 milestone Sep 22, 2021
@94noni 94noni changed the base branch from 5.3 to 4.4 September 22, 2021 16:17
fabpot
fabpot requested changes Sep 23, 2021
View reviewed changes
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a small suggestion for the error message

@94noni
Copy link
Contributor Author

94noni commented Sep 23, 2021 •
edited
Loading

@fabpot comment addressed, thx
also carsonbot added this to the 5.3 milestone 16 hours ago as I first targeted 5.3, but it should be 4.4 instead

@nicolas-grekas
Copy link
Member

Thank you @94noni.

@nicolas-grekas nicolas-grekas merged commit 1636a26 into symfony:4.4 Sep 24, 2021
@nicolas-grekas nicolas-grekas modified the milestones: 5.3, 4.4 Sep 24, 2021
@94noni 94noni deleted the ft-secret-command branch September 24, 2021 16:57
This was referenced Sep 28, 2021
Merged
Merged
@petrisorciprian-vitals petrisorciprian-vitals mentioned this pull request Jun 26, 2024
Closed
@xabbuh xabbuh mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot requested changes

Assignees
No one assigned
Labels
Bug FrameworkBundle
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@94noni @nicolas-grekas @fabpot @carsonbot @noniagriconomie