Skip to content

[Messenger] Add Redis Sentinel support #43163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2022
Merged

[Messenger] Add Redis Sentinel support #43163

merged 1 commit into from
Mar 31, 2022

Conversation

norbertschultheisz
Copy link
Contributor

@norbertschultheisz norbertschultheisz commented Sep 24, 2021 •
edited
Loading

Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets Issue #41762
License MIT
Doc PR symfony/symfony-docs#16113

@carsonbot carsonbot added this to the 5.3 milestone Sep 24, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@norbertschultheisz norbertschultheisz force-pushed the redis-messenger-sentinel-support branch 3 times, most recently from fb45af6 to 9aabcfa Compare September 24, 2021 11:58
nicolas-grekas
nicolas-grekas reviewed Sep 24, 2021
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR.
Since this is a new feature, it should target 5.4. Can you please rebase+retarget against 5.4?

@nicolas-grekas nicolas-grekas changed the title [Messenger] [Redis] Redis Sentinel support- issue #41762 [Messenger] Add Redis Sentinel support Sep 24, 2021
@norbertschultheisz norbertschultheisz force-pushed the redis-messenger-sentinel-support branch from 9aabcfa to f32af46 Compare September 25, 2021 08:45
@norbertschultheisz norbertschultheisz force-pushed the redis-messenger-sentinel-support branch 2 times, most recently from b40b95f to ab8bd78 Compare September 25, 2021 10:17
@lyrixx lyrixx changed the base branch from 5.3 to 5.4 September 25, 2021 11:09
@norbertschultheisz norbertschultheisz force-pushed the redis-messenger-sentinel-support branch from ab8bd78 to dacb2b1 Compare September 25, 2021 13:25
@norbertschultheisz norbertschultheisz marked this pull request as draft September 25, 2021 13:47
@nicolas-grekas nicolas-grekas modified the milestones: 5.3, 5.4 Sep 26, 2021
nicolas-grekas
nicolas-grekas reviewed Sep 26, 2021
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the draft label when you're ready.

@norbertschultheisz norbertschultheisz force-pushed the redis-messenger-sentinel-support branch from dacb2b1 to 2ac1f39 Compare October 6, 2021 12:32
@norbertschultheisz norbertschultheisz force-pushed the redis-messenger-sentinel-support branch from bd7d988 to 29c0793 Compare October 12, 2021 08:02
@fabpot fabpot modified the milestones: 5.4, 6.1 Oct 29, 2021
@norbertschultheisz norbertschultheisz force-pushed the redis-messenger-sentinel-support branch 2 times, most recently from 247ea6e to 9c02ef3 Compare November 16, 2021 10:24
@norbertschultheisz norbertschultheisz marked this pull request as ready for review November 16, 2021 11:38
@carsonbot carsonbot modified the milestones: 6.1, 5.4 Nov 16, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you.

Cheers!

Carsonbot

@fabpot fabpot modified the milestones: 5.4, 6.1 Nov 17, 2021
@norbertschultheisz norbertschultheisz force-pushed the redis-messenger-sentinel-support branch 2 times, most recently from 15be629 to cd4df2d Compare December 29, 2021 09:16
@norbertschultheisz norbertschultheisz force-pushed the redis-messenger-sentinel-support branch from cd4df2d to e529559 Compare February 4, 2022 08:41
@norbertschultheisz norbertschultheisz force-pushed the redis-messenger-sentinel-support branch 2 times, most recently from 8230577 to 12aa5e9 Compare March 23, 2022 07:42
nicolas-grekas
nicolas-grekas reviewed Mar 29, 2022
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay reviewing this PR and thanks for it!
Here are some comments to move the needle forward.

@norbertschultheisz norbertschultheisz force-pushed the redis-messenger-sentinel-support branch 2 times, most recently from e1b00ea to 58dd1de Compare March 31, 2022 07:17
@norbertschultheisz norbertschultheisz force-pushed the redis-messenger-sentinel-support branch from 58dd1de to 07de048 Compare March 31, 2022 07:28
nicolas-grekas
nicolas-grekas approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've cleaned up the Redis Connection class in 6c5f289 because it was too fragile.

@nicolas-grekas
Copy link
Member

Thank you @norbertschultheisz.

nicolas-grekas added a commit that referenced this pull request Mar 31, 2022
@nicolas-grekas
feature #43163 [Messenger] Add Redis Sentinel support (norbertschulth…
39a69bb 
…eisz)

This PR was merged into the 6.1 branch.

Discussion
----------

[Messenger] Add Redis Sentinel support

| Q             | A
| ------------- | ---
| Branch?       | 6.1
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | Issue #41762
| License       | MIT
| Doc PR        | symfony/symfony-docs#16113

Commits
-------

6c5f289 [Messenger] cleanup creation logic in Redis Connection class
07de048 [Messenger] [Redis] Redis Sentinel support - issue #41762
@nicolas-grekas nicolas-grekas merged commit 07de048 into symfony:6.1 Mar 31, 2022
@javiereguiluz javiereguiluz mentioned this pull request Apr 6, 2022
Merged
@fabpot fabpot mentioned this pull request Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@sroze sroze Awaiting requested review from sroze

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@jderusse jderusse Awaiting requested review from jderusse

@lyrixx lyrixx Awaiting requested review from lyrixx

@OskarStark OskarStark Awaiting requested review from OskarStark

@wouterj wouterj Awaiting requested review from wouterj

@xabbuh xabbuh Awaiting requested review from xabbuh

@yceruto yceruto Awaiting requested review from yceruto

Assignees
No one assigned
Labels
Feature Messenger Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.
4 participants
@norbertschultheisz @carsonbot @nicolas-grekas @fabpot