[Serializer] Fix denormalizing XML array with empty body (5.x) #43204
+25
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I think @mkrauser has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
lyrixx
approved these changes
Sep 28, 2021
dunglas
requested changes
Sep 28, 2021
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
6470a7a to
44c7114
Compare
dunglas
approved these changes
Sep 28, 2021
src/Symfony/Component/Serializer/Normalizer/AbstractObjectNormalizer.php
Outdated
Show resolved
Hide resolved
This happens for example with XML empty tags denormalizing to an object array attribute.
44c7114 to
d94b7c1
Compare
fabpot
approved these changes
Sep 29, 2021
fabpot
added a commit
that referenced
this pull request
Sep 29, 2021
…4.4) (alexandre-daubois) This PR was merged into the 4.4 branch. Discussion ---------- [Serializer] Fix denormalizing XML array with empty body (4.4) This happens for example with XML empty tags denormalizing to an object array attribute. | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #43193 on Symfony 4.4 | License | MIT | Doc PR | _NA_ Not sure how to deal with versions differences as they differ just a little bit. Anyway, here's the fix for 4.4 and you can find the fix for 5.x on #43204 😄 Commits ------- d6b7e2d [Serializer] Fix denormalizing of array with empty body
|
Thank you @alexandre-daubois. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens for example with XML empty tags denormalizing to an object array attribute.
Fix for 4.4 can be found in #43205