Skip to content

[Serializer] Fix denormalizing XML array with empty body (4.4) #43205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2021

Conversation

alexandre-daubois
Copy link
Member

This happens for example with XML empty tags denormalizing to an object array attribute.

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #43193 on Symfony 4.4
License MIT
Doc PR NA

Not sure how to deal with versions differences as they differ just a little bit. Anyway, here's the fix for 4.4 and you can find the fix for 5.x on #43204 😄

This happens for example with XML empty tags denormalizing to an object array attribute.
@carsonbot carsonbot added this to the 4.4 milestone Sep 27, 2021
@alexandre-daubois alexandre-daubois changed the title [Serializer] Fix denormalizing of array with empty body [Serializer] Fix denormalizing of array with empty body (4.4) Sep 27, 2021
@alexandre-daubois alexandre-daubois changed the title [Serializer] Fix denormalizing of array with empty body (4.4) [Serializer] Fix denormalizing XML array with empty body (4.4) Sep 28, 2021
@fabpot
Copy link
Member

fabpot commented Sep 29, 2021

Thank you @alexandre-daubois.

@fabpot fabpot merged commit 0eac61e into symfony:4.4 Sep 29, 2021
fabpot added a commit that referenced this pull request Sep 29, 2021
…5.x) (alexandre-daubois)

This PR was merged into the 5.3 branch.

Discussion
----------

[Serializer] Fix denormalizing XML array with empty body (5.x)

This happens for example with XML empty tags denormalizing to an object array attribute.

| Q             | A
| ------------- | ---
| Branch?       | 5.3
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #43193 on Symfony 5.x
| License       | MIT
| Doc PR        | _NA_

Fix for 4.4 can be found in #43205

Commits
-------

d94b7c1 [Serializer] Fix denormalizing of array with empty body
@alexandre-daubois alexandre-daubois deleted the fix/xml-empty-array-44 branch September 29, 2021 06:50
This was referenced Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants