[Workflow] Add missing audit-trail settings in framework workflow con… #43206
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
271a525 to
ec55c22
Compare
|
Thanks for finding this issue Could you update some test to ensure not regression could happen? Thanks |
ec55c22 to
6d2b71e
Compare
Just pushed the test! |
|
Thank you @temp. |
| <xsd:attribute name="enabled" type="xsd:boolean" /> | ||
| </xsd:complexType> | ||
|
|
||
| <xsd:simpleType name="audit_trail_enabled"> |
This PR was merged into the 5.3 branch. Discussion ---------- [Workflow] Remove unused code in XML schemas | Q | A | ------------- | --- | Branch? | 5.3 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #43206 (review) | License | MIT | Doc PR | Commits ------- 0ef7789 [Workflow] Remove dead code in XML schemas
audit-trail config was missing in xsd. Example from symfony.com did not work as expected due to this.
Commit adds audit-trail in xsd