Skip to content

[Serializer] Attributes that extend serializer`s annotations are not ignored by the serialization process #43208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2021
Merged

[Serializer] Attributes that extend serializer`s annotations are not ignored by the serialization process #43208

merged 1 commit into from
Sep 29, 2021
+71 −8

Conversation

onatskyy
Copy link

@onatskyy onatskyy commented Sep 28, 2021 •
edited
Loading

Q A
Branch? 5.3 for bug fixes
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #43207
License MIT
Doc PR

@onatskyy onatskyy requested a review from dunglas as a code owner September 28, 2021 08:21
@carsonbot carsonbot added this to the 5.4 milestone Sep 28, 2021
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 5.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@onatskyy onatskyy changed the base branch from 5.4 to 5.3 September 28, 2021 08:31
@onatskyy onatskyy changed the title [Serializer] Attributes that extends the serializer`s annotations do … [Serializer] Attributes that extend serializer`s annotations are not ignored by the serialization process Sep 28, 2021
dunglas
dunglas reviewed Sep 29, 2021
View reviewed changes
Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe should we have marked these news attributes as final as I'm not sure that it's a good practice to extend them. But LGTM otherwise.

@nicolas-grekas nicolas-grekas modified the milestones: 5.4, 5.3 Sep 29, 2021
@nicolas-grekas
Copy link
Member

Thank you @onatskyy.

@nicolas-grekas nicolas-grekas merged commit 545fc34 into symfony:5.3 Sep 29, 2021
@fabpot fabpot mentioned this pull request Oct 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

@kester36 kester36 kester36 approved these changes

Assignees
No one assigned
Labels
Bug Serializer Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
5 participants
@onatskyy @carsonbot @nicolas-grekas @dunglas @kester36