Skip to content

[Security] Remove annoying deprecation in UsageTrackingTokenStorage #43235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2021
Merged

[Security] Remove annoying deprecation in UsageTrackingTokenStorage #43235

merged 1 commit into from
Sep 29, 2021

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Sep 28, 2021

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #43042
License MIT
Doc PR -

@chalasr chalasr requested a review from wouterj as a code owner September 28, 2021 12:35
@carsonbot carsonbot added this to the 5.3 milestone Sep 28, 2021
@chalasr chalasr force-pushed the security-helper-noreq branch 2 times, most recently from e4822ca to 8b0d79f Compare September 28, 2021 12:36
@chalasr chalasr mentioned this pull request Sep 28, 2021
Closed
@chalasr chalasr force-pushed the security-helper-noreq branch 3 times, most recently from 07b7ffc to 152024e Compare September 28, 2021 13:10
jderusse
jderusse approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@jderusse jderusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpicking

@chalasr
Copy link
Member Author

chalasr commented Sep 28, 2021

There might be a simpler solution: #43042 (comment).
Don't merge yet.

@chalasr chalasr force-pushed the security-helper-noreq branch from 152024e to 06f4663 Compare September 28, 2021 22:00
@chalasr chalasr changed the title [Security] Disable session usage tracking from Security helper when there is no request [Security] Remove annoying deprecation in UsageTrackingTokenStorage Sep 28, 2021
@chalasr
Copy link
Member Author

chalasr commented Sep 28, 2021

PR updated to revert the deprecation instead. It was introduced in #40785 but is not strictly needed.

@fabpot
Copy link
Member

fabpot commented Sep 29, 2021

Thank you @chalasr.

@fabpot fabpot merged commit 4b3d3e0 into symfony:5.3 Sep 29, 2021
@chalasr chalasr deleted the security-helper-noreq branch September 29, 2021 11:16
@derrabus
Copy link
Member

@chalasr Can you please do the merge from 5.4 to 6.0? I was unsure if I need to revert anything when merging up, now that the deprecation has been reverted.

@chalasr
Copy link
Member Author

chalasr commented Sep 30, 2021

@derrabus sure, done

@fabpot fabpot mentioned this pull request Oct 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@jderusse jderusse jderusse approved these changes

@derrabus derrabus derrabus approved these changes

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

Assignees
No one assigned
Labels
Bug Security Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
5 participants
@chalasr @fabpot @derrabus @jderusse @carsonbot