Skip to content

[PhpUnitBridge] Fix skipping triggering file override for missing return types on 5.3 #43251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 30, 2021
Merged

[PhpUnitBridge] Fix skipping triggering file override for missing return types on 5.3 #43251

merged 1 commit into from
Sep 30, 2021

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Sep 30, 2021 •
edited
Loading

Q A
Branch? 5.3
Bug fix? yes
New feature? no
Deprecations? -
Tickets -
License MIT
Doc PR -

#43241 was merged in 5.3 instead of 5.4, but the deprecation notice was reworded on 5.4: #42935.

@carsonbot carsonbot added this to the 5.3 milestone Sep 30, 2021
@carsonbot carsonbot changed the title [PHPUnitBridge] Fix skipping triggering file override for missing return types on 5.3 [PhpUnitBridge] Fix skipping triggering file override for missing return types on 5.3 Sep 30, 2021
@nicolas-grekas
Copy link
Member

Thank you @chalasr.

@nicolas-grekas nicolas-grekas merged commit fc8fe04 into symfony:5.3 Sep 30, 2021
@chalasr chalasr deleted the deprec-return-txt branch September 30, 2021 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug PhpUnitBridge Status: Reviewed
Projects
None yet
Milestone
5.3
Development

Successfully merging this pull request may close these issues.
3 participants
@chalasr @nicolas-grekas @carsonbot