Possibility to configure directory for warmup (kernel.warmup_dir) #43257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As the comment above the changed lines tell:
Adding a parameter for that would prevent enforcing that rule and we'd have to throw an exception. To cover your use case, I would recommend you to warmup the Symfony app in a local directory, then to move it to NFS, if that's applicable. I'm closing because this didn't get traction and won't be accepted for the reason I just gave IMHO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to optionally configure the location where the cache warmup should be done.
#36515 introduced already the possibility to have a custom build location, but sometimes it would be also very handy to change the warmup directory as well, especially if you're on a network filesystem such as NFS.
Then you could point the
kernel.warmup_dire.g. to/tmp/symfony-warmupwhere the build is much faster.